Copilot commented on code in PR #104: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/104#discussion_r4035406477
########## README.md: ########## @@ -390,9 +393,14 @@ account when migrating from the old cloud provider to the standalone controller. ### Load Balancer -Load balancer rule names now include the protocol in addition to the LB name and service port. -This was added to distinguish tcp, udp and tcp-proxy services operating on the same port. -Without this change, it would not be possible to map a service that runs on both TCP and UDP port 8000, for example. +Load balancer rule names now include the protocol in addition to the LB name and service port, so +that a rule identifies the protocol it serves. The controller keeps the name in step with the +protocol, so a rule renamed from `-tcp-` to `-tcp-proxy-` reflects a protocol change rather than a +new rule. Review Comment: The migration warning below now conflicts with the behavior documented here: `findLoadBalancerRule` deliberately falls back from the new protocol-bearing name to the existing rule's IP protocol/port, and the update path renames that matched rule. Legacy rules should therefore be adopted and renamed rather than requiring operators to delete them first; please update the migration instructions so they do not prescribe unnecessary destructive cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
