poddm commented on PR #315: URL: https://github.com/apache/cloudstack-terraform-provider/pull/315#issuecomment-5511695949
Thanks @sudo87 — all four addressed: 1. **Dead code / no drift detection** — `commonRead()` now writes the nested `gpu` object back to state (`state.ServiceOfferingGpu = obj`) before `resp.State.Set`, and nulls `vgpu_profile_id`/`count` when the API returns empty/0, so out-of-band changes are detected. 2. **Host-scoped vGPU IDs / ambiguity** — vGPU profiles are GPU-card–scoped, not host-scoped (`listVgpuProfiles` has no host/zone param), so the profile UUID is the correct global ID. The real gap is fixed: data sources now error on multiple matches (narrow via `gpu_card_id`) and reject duplicate filter names. 3. **Name vs ID confusion** — tests no longer hardcode a profile name; they look it up via the data source (`vgpu_profile_id = data.cloudstack_vgpu_profile.test.id`) and assert with `TestCheckResourceAttrPair`. Tests, docs, schema, and API now all treat it as the UUID. 4. **Server-side filters** — reflection/regex layer removed; filters map directly to `listVgpuProfiles`/`listGpuCards` params (`id`, `name`, `gpu_card_id`, `vendor_id`, `device_id`, `device_name`, `keyword`, `active_only`), combine as AND, and error on unsupported names (card `name` → `keyword`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
