bhouse-nexthop commented on PR #280: URL: https://github.com/apache/cloudstack-terraform-provider/pull/280#issuecomment-5293229274
@sureshanaparti @sudo87 both outstanding Copilot comments are addressed in 1be6cbb. Both were the same underlying issue: `resourceCloudStackNetworkACLRead` and `resourceCloudStackPortForwardRead` scoped their lookups to the `project` in state, so an empty `project` (imported resource, state from an older provider version, or an inherited project whose name the API didn't return) made the project-scoped lookup return `count == 0` and silently cleared the resource from state. Both now retry with `projectid=-1` when the state project is empty and nothing was found - the same fallback the network, instance and ipaddress resources in this PR already use. That also covers the two suppressed low-confidence comments, which flagged the same two call sites. Conflicts were already resolved in a0f9fec; GitHub reports the PR as mergeable against current main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
