Copilot commented on code in PR #143:
URL: https://github.com/apache/cloudstack-go/pull/143#discussion_r3719570856
##########
cloudstack/BackupService.go:
##########
@@ -668,32 +669,16 @@ func (s *BackupService) CreateBackupSchedule(p
*CreateBackupScheduleParams) (*Cr
}
type CreateBackupScheduleResponse struct {
- Account string `json:"account"`
- Accountid string `json:"accountid"`
- Backupofferingid string `json:"backupofferingid"`
- Backupofferingname string `json:"backupofferingname"`
- Created string `json:"created"`
- Description string `json:"description"`
- Domain string `json:"domain"`
- Domainid string `json:"domainid"`
- Externalid string `json:"externalid"`
- Id string `json:"id"`
- Intervaltype string `json:"intervaltype"`
- Isbackupvmexpunged bool `json:"isbackupvmexpunged"`
- JobID string `json:"jobid"`
- Jobstatus int `json:"jobstatus"`
- Name string `json:"name"`
- Size int64 `json:"size"`
- Status string `json:"status"`
- Type string `json:"type"`
- Virtualmachineid string `json:"virtualmachineid"`
- Virtualmachinename string `json:"virtualmachinename"`
- Virtualsize int64 `json:"virtualsize"`
- Vmbackupofferingremoved bool
`json:"vmbackupofferingremoved"`
- Vmdetails map[string]string `json:"vmdetails"`
- Volumes string `json:"volumes"`
- Zone string `json:"zone"`
- Zoneid string `json:"zoneid"`
+ Id string `json:"id"`
+ Intervaltype string `json:"intervaltype"`
+ JobID string `json:"jobid"`
+ Jobstatus int `json:"jobstatus"`
+ Maxbackups int `json:"maxbackups"`
+ Quiescevm bool `json:"quiescevm"`
+ Schedule string `json:"schedule"`
+ Timezone string `json:"timezone"`
+ Virtualmachineid string `json:"virtualmachineid"`
+ Virtualmachinename string `json:"virtualmachinename"`
Review Comment:
`CreateBackupScheduleResponse` was drastically reduced (many previously
available fields were removed). Even if the server no longer returns those
fields, removing them from the client type is a compile-time breaking change
for consumers. Consider retaining the previously generated fields (they can
remain unused/empty) and adding the new fields, or introducing a
versioned/alternate response type if you need to represent different API
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
