CodeBleu commented on PR #240: URL: https://github.com/apache/cloudstack-terraform-provider/pull/240#issuecomment-3381685855
> clgtm except for one thing (and I realise this problem is not introduced in this PR) the methods are too big. If you can please factor out some blocks with their heading comments. Because there is another WIP PR for this same resource #239, I'm going to go ahead and merge this now because it fixes the existing functionality. I don't want to change things and have to go through more testing again right now so it can hopefully make it into the 4.22 release. > ...factor out some blocks with their heading comments. Not sure exactly which comments you are referring to, but I feel like comments are good to explain what is going on. If there are some to be refactored out, then maybe with @Pearl1594 PR they can be cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
