Copilot commented on code in PR #118:
URL: https://github.com/apache/cloudstack-go/pull/118#discussion_r2314969824
##########
generate/generate.go:
##########
@@ -54,10 +54,23 @@ var detailsRequireKeyValue = map[string]bool{
// detailsRequireZeroIndex is a prefilled map with a list of details
// that need to be encoded using zero indexing
var detailsRequireZeroIndex = map[string]bool{
- "registerTemplate": true,
- "updateTemplate": true,
- "createAccount": true,
- "updateAccount": true,
+ "registerTemplate": true,
+ "updateTemplate": true,
+ "createAccount": true,
+ "updateAccount": true,
+ "updateVirtualMachine": true,
+}
+
+// parametersRequireIndexing contains map parameters that always need
+// index variables (i) even when the command uses zero indexing
Review Comment:
The comment should clarify what 'index variables (i)' means in this context.
Consider explaining that these parameters need sequential indexing (0, 1, 2...)
rather than static zero indexing.
```suggestion
// index variables (i.e., sequential indexing: 0, 1, 2, ...) for their
entries,
// rather than static zero indexing, even when the command itself uses zero
indexing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
