I went looking for other uses of vm_data.sh in the CitrixResourceBase.java and didn't find it, hence the reason why I removed it. I already knew vmware used their own method. In looking more closely, I see that CitrixResourceBase calls a host plugin called "vm_data", that must later depend on vm_data.sh somewhere down the line, not sure how that works.
Actually, now I see there's a "vmops" python script that this resides in. The CitrixResourceBase seems to split the functionality seen in VirtualRoutingResource for KVM between these two files. I've concocted a totally untested patch that would switch Xen over to the same functionality, if it works it would probably speed up VR deployments for them as well. We can then remove vm_data.sh and remove the vm_data function from vmops as well. I'm not set up to test it at the moment. https://reviews.apache.org/r/12972/ On Fri, Jul 26, 2013 at 10:11 AM, Prasanna Santhanam <t...@apache.org> wrote: > Seems like we'll have to take care of both when changing userdata in > the future - shell + python. Any chance we can make this work for Xen > too using python or is that not possible? > > On Thu, Jul 25, 2013 at 05:52:59PM -0600, Marcus Sorensen wrote: >> Thanks for taking care of that. >> >> On Thu, Jul 25, 2013 at 5:30 PM, Sheng Yang <sh...@yasker.org> wrote: >> > Hi Marcus, >> > >> > Xen's vm_data has been broken since this commit, because the file >> > scripts/network/domr/vm_data.sh you deleted is shared by Xen as well. >> > >> > commit 28855b4987c9274d15a539b9d7ae26c0073b0651 >> > Author: Marcus Sorensen <mar...@betterservers.com> >> > Date: Wed Jul 24 13:58:17 2013 -0600 >> > >> > Summary: Get away from dozens of ssh/scp calls for KVM vm_data push >> > >> > Detail: userdata and vm metadata take a long time to program on KVM >> > routers. >> > This does it all in one go, processed on the router. >> > >> > BUG-ID: CLOUDSTACK-3163 >> > Tested-by: Wido >> > Signed-off-by: Marcus Sorensen <mar...@betterservers.com> 1374695897 >> > -0600 >> > >> > I would bring the file back now. >> > >> > Thanks. >> > >> > --Sheng > > -- > Prasanna., > > ------------------------ > Powered by BigRock.com >
