shwstppr commented on code in PR #161:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/161#discussion_r2032513039
##########
cmd/network.go:
##########
@@ -204,6 +204,8 @@ func NewAPIRequest(r *Request, api string, args []string,
isAsync bool) (map[str
}
}
params.Add("response", "json")
+ params.Add("signatureversion", "3")
+ params.Add(expiresKey, time.Now().UTC().Add(15 *
time.Minute).Format(time.RFC3339))
Review Comment:
build failing here
##########
cmd/network.go:
##########
@@ -204,6 +204,10 @@ func NewAPIRequest(r *Request, api string, args []string,
isAsync bool) (map[str
}
}
params.Add("response", "json")
+ params.Add("signatureversion", "3")
Review Comment:
Upto you @kevin-lii
I wouldn't mind adding some constants in the same file itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
