vits-hugs opened a new pull request, #159: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/159
### Description Right now, the autocomplete of the `storageid` parameter on the `migrateSystemVm` API is returning system VMs IDs instead of the expected storage IDs, as shown below. This bug also sets the CloudMonkey autocomplete cache for others APIs, such as `migrateVirtualMachine`. ``` Apache CloudStack 🐵 CloudMonkey 6.4.0 Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues (localcloud) 🐱 > migrate systemvm storageid= 0124fcb6-ca16-421e-b332-d1438f63ac5a (v-12-VM) 159e8d32-5f74-41b1-ba17-8b0e734143f0 (s-14-VM) (localcloud) 🐱 > migrate virtualmachine storageid= 0124fcb6-ca16-421e-b332-d1438f63ac5a (v-12-VM) 159e8d32-5f74-41b1-ba17-8b0e734143f0 (s-14-VM) ``` This PR corrects this, by adding a verification, so the `autocompleteAPI` struct only changes it's `Name` member to `listSystemVms` when it's defined to `listVirtualMachines`, thus not calling the `listSystemVms` API to autocomplete the `storageid` parameter. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? On CloudMonkey the autocomplete of all parameters in `migrateSystemVm` was called, and verified to be the correct answer, as shown below. ``` Apache CloudStack 🐵 CloudMonkey 6.4.0 Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues (localcloud) 🐱 > migrate systemvm storageid= 10d65800-bbda-347a-bbb0-250e6d7d1586 (nfs-1) 817d7155-a725-4cf7-b2bb-bc14b238eb4a (iscsi-1) (localcloud) 🐱 > migrate systemvm virtualmachineid= 0124fcb6-ca16-421e-b332-d1438f63ac5a (v-12-VM) 159e8d32-5f74-41b1-ba17-8b0e734143f0 (s-14-VM) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
