NuxRo commented on code in PR #487:
URL: 
https://github.com/apache/cloudstack-documentation/pull/487#discussion_r1988995049


##########
source/adminguide/events.rst:
##########
@@ -59,6 +59,14 @@ machine on the event bus. All the CloudStack events (alerts, 
action
 events, usage events) and the additional category of resource state
 change events, are published on to the events bus.
 
+.. note::
+   Alerts for some more important events will be send multiple
+   times for the same event. This is due to the nature of guarding

Review Comment:
   ```suggestion
      times. This is due to the nature of guarding
   ```



##########
source/adminguide/events.rst:
##########
@@ -59,6 +59,14 @@ machine on the event bus. All the CloudStack events (alerts, 
action
 events, usage events) and the additional category of resource state
 change events, are published on to the events bus.
 
+.. note::
+   Alerts for some more important events will be send multiple
+   times for the same event. This is due to the nature of guarding
+   certain resources from multiple threads in the code, to make sure
+   that events are not missed. Examples are "Host down" or
+   "HA starting VM". These are considered to important to not send

Review Comment:
   ```suggestion
      "HA starting VM". These are considered too important to not send
   ```



##########
source/adminguide/events.rst:
##########
@@ -59,6 +59,14 @@ machine on the event bus. All the CloudStack events (alerts, 
action
 events, usage events) and the additional category of resource state
 change events, are published on to the events bus.
 
+.. note::
+   Alerts for some more important events will be send multiple

Review Comment:
   ```suggestion
      Alerts for some more important events will be sent multiple
   ```



##########
source/adminguide/events.rst:
##########
@@ -59,6 +59,14 @@ machine on the event bus. All the CloudStack events (alerts, 
action
 events, usage events) and the additional category of resource state
 change events, are published on to the events bus.
 
+.. note::
+   Alerts for some more important events will be send multiple
+   times for the same event. This is due to the nature of guarding
+   certain resources from multiple threads in the code, to make sure
+   that events are not missed. Examples are "Host down" or
+   "HA starting VM". These are considered to important to not send
+   immediately and hence a check if they are queued can not be done.

Review Comment:
   ```suggestion
      immediately and hence a check if they are already queued can not be done.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to