andrijapanicsb commented on code in PR #453:
URL: 
https://github.com/apache/cloudstack-documentation/pull/453#discussion_r1833358158


##########
source/adminguide/virtual_machines/importing_vmware_vms_into_kvm.rst:
##########
@@ -113,11 +113,32 @@ In the UI to import instance, you can optionally select a 
KVM host and temporary
 
 |import-vm-from-vmware-to-kvm-options.png|
 
-When importing a Virtual Machine from VMware to KVM, CloudStack performs the 
following actions:
-
-    - Clones the Source Virtual Machine on the selected VMware Datacenter for 
running VMs: The source Virtual Machine will be cloned in the original state 
for running VMs. The recommended state is the stopped state to prevent data 
inconsistencies or loss when cloning the virtual machine.
-    - Imports the VM files (OVF) of the Cloned Virtual Machine for running 
VMs, Source Virtual Machine for stopped VMs to a temporary storage location 
(which can be selected by the administrator) from KVM host if ovftool installed 
or management server (can be forced by the administrator).
-    - Converts the OVF on the temporary storage location to KVM using 
virt-v2v: CloudStack (or the administrator) selects a running and enabled KVM 
host to perform the conversion from VMware to KVM using **virt-v2v**. If the 
binary is not installed, then the host will fail the migration. In case it is 
installed, it will perform the conversion into the temporary location to store 
the converted QCOW2 disks of the virtual machine. The disks are then moved into 
the destination storage pools for the virtual machine. The conversion is a 
long-lasting process which can be set to time out by the global setting 
'convert.vmware.instance.to.kvm.timeout'. The conversion processes takes a long 
time because virt-v2v creates a temporary virtual machine to inspect the source 
VM and generate the converted disks with the correct drivers. Additionally, it 
needs to copy the converted disks into the temporary location.
+When importing a instance from VMware to KVM, CloudStack performs the 
following actions:
+
+    - Clones the Source Instance on the selected VMware Datacenter for running
+    VMs: The source instance will be cloned in the original state for running
+    VMs. The recommended state is the stopped state to prevent data
+    inconsistencies or loss when cloning the instance.
+    - Imports the VM files (OVF) of the Cloned instance for running VMs, Source
+    Instance for stopped VMs to a temporary storage location (which can be
+    selected by the administrator) from KVM host if ovftool installed or

Review Comment:
   How do we check for ovftool presence - you might need help from the feature 
author - please add short explanation



##########
source/adminguide/virtual_machines/importing_vmware_vms_into_kvm.rst:
##########
@@ -113,11 +113,32 @@ In the UI to import instance, you can optionally select a 
KVM host and temporary
 
 |import-vm-from-vmware-to-kvm-options.png|
 
-When importing a Virtual Machine from VMware to KVM, CloudStack performs the 
following actions:
-
-    - Clones the Source Virtual Machine on the selected VMware Datacenter for 
running VMs: The source Virtual Machine will be cloned in the original state 
for running VMs. The recommended state is the stopped state to prevent data 
inconsistencies or loss when cloning the virtual machine.
-    - Imports the VM files (OVF) of the Cloned Virtual Machine for running 
VMs, Source Virtual Machine for stopped VMs to a temporary storage location 
(which can be selected by the administrator) from KVM host if ovftool installed 
or management server (can be forced by the administrator).
-    - Converts the OVF on the temporary storage location to KVM using 
virt-v2v: CloudStack (or the administrator) selects a running and enabled KVM 
host to perform the conversion from VMware to KVM using **virt-v2v**. If the 
binary is not installed, then the host will fail the migration. In case it is 
installed, it will perform the conversion into the temporary location to store 
the converted QCOW2 disks of the virtual machine. The disks are then moved into 
the destination storage pools for the virtual machine. The conversion is a 
long-lasting process which can be set to time out by the global setting 
'convert.vmware.instance.to.kvm.timeout'. The conversion processes takes a long 
time because virt-v2v creates a temporary virtual machine to inspect the source 
VM and generate the converted disks with the correct drivers. Additionally, it 
needs to copy the converted disks into the temporary location.
+When importing a instance from VMware to KVM, CloudStack performs the 
following actions:
+
+    - Clones the Source Instance on the selected VMware Datacenter for running
+    VMs: The source instance will be cloned in the original state for running
+    VMs. The recommended state is the stopped state to prevent data
+    inconsistencies or loss when cloning the instance.
+    - Imports the VM files (OVF) of the Cloned instance for running VMs, Source
+    Instance for stopped VMs to a temporary storage location (which can be
+    selected by the administrator) from KVM host if ovftool installed or
+    management server (can be forced by the administrator).
+    - Converts the OVF on the temporary storage location to KVM using virt-v2v:
+    CloudStack (or the administrator) selects a running and enabled KVM host to
+    perform the conversion from VMware to KVM using **virt-v2v**. If the binary
+    is not installed, then the host will fail the migration. In case it is
+    installed, it will perform the conversion into the temporary location to
+    store the converted QCOW2 disks of the instance. The disks are then moved
+    into the destination storage pools for the instance. The conversion is a
+    long-lasting process which can be set to time out by the global setting
+    'convert.vmware.instance.to.kvm.timeout'. The conversion processes takes a
+    long time because virt-v2v creates a temporary instance to inspect the
+    source VM and generate the converted disks with the correct
+    drivers. Additionally, it needs to copy the converted disks into
+    the temporary location.
+    - The converted instance is then imported into the selected KVM cluster.
+    The instance for conversion is selected randomly from the selected

Review Comment:
   Wrong wording "The instance for conversion is selected..."  - should it be 
"The host to perform the qcow2/etc conversion is selected randomly"



##########
source/adminguide/virtual_machines/importing_vmware_vms_into_kvm.rst:
##########
@@ -113,11 +113,32 @@ In the UI to import instance, you can optionally select a 
KVM host and temporary
 
 |import-vm-from-vmware-to-kvm-options.png|
 
-When importing a Virtual Machine from VMware to KVM, CloudStack performs the 
following actions:
-
-    - Clones the Source Virtual Machine on the selected VMware Datacenter for 
running VMs: The source Virtual Machine will be cloned in the original state 
for running VMs. The recommended state is the stopped state to prevent data 
inconsistencies or loss when cloning the virtual machine.
-    - Imports the VM files (OVF) of the Cloned Virtual Machine for running 
VMs, Source Virtual Machine for stopped VMs to a temporary storage location 
(which can be selected by the administrator) from KVM host if ovftool installed 
or management server (can be forced by the administrator).
-    - Converts the OVF on the temporary storage location to KVM using 
virt-v2v: CloudStack (or the administrator) selects a running and enabled KVM 
host to perform the conversion from VMware to KVM using **virt-v2v**. If the 
binary is not installed, then the host will fail the migration. In case it is 
installed, it will perform the conversion into the temporary location to store 
the converted QCOW2 disks of the virtual machine. The disks are then moved into 
the destination storage pools for the virtual machine. The conversion is a 
long-lasting process which can be set to time out by the global setting 
'convert.vmware.instance.to.kvm.timeout'. The conversion processes takes a long 
time because virt-v2v creates a temporary virtual machine to inspect the source 
VM and generate the converted disks with the correct drivers. Additionally, it 
needs to copy the converted disks into the temporary location.
+When importing a instance from VMware to KVM, CloudStack performs the 
following actions:
+
+    - Clones the Source Instance on the selected VMware Datacenter for running
+    VMs: The source instance will be cloned in the original state for running
+    VMs. The recommended state is the stopped state to prevent data
+    inconsistencies or loss when cloning the instance.
+    - Imports the VM files (OVF) of the Cloned instance for running VMs, Source
+    Instance for stopped VMs to a temporary storage location (which can be
+    selected by the administrator) from KVM host if ovftool installed or
+    management server (can be forced by the administrator).

Review Comment:
   How (I was told there is additional API parameter - but can't seem to see it 
in the API docs (I might have missed it)?



##########
source/adminguide/virtual_machines/importing_vmware_vms_into_kvm.rst:
##########
@@ -113,11 +113,32 @@ In the UI to import instance, you can optionally select a 
KVM host and temporary
 
 |import-vm-from-vmware-to-kvm-options.png|
 
-When importing a Virtual Machine from VMware to KVM, CloudStack performs the 
following actions:
-
-    - Clones the Source Virtual Machine on the selected VMware Datacenter for 
running VMs: The source Virtual Machine will be cloned in the original state 
for running VMs. The recommended state is the stopped state to prevent data 
inconsistencies or loss when cloning the virtual machine.
-    - Imports the VM files (OVF) of the Cloned Virtual Machine for running 
VMs, Source Virtual Machine for stopped VMs to a temporary storage location 
(which can be selected by the administrator) from KVM host if ovftool installed 
or management server (can be forced by the administrator).
-    - Converts the OVF on the temporary storage location to KVM using 
virt-v2v: CloudStack (or the administrator) selects a running and enabled KVM 
host to perform the conversion from VMware to KVM using **virt-v2v**. If the 
binary is not installed, then the host will fail the migration. In case it is 
installed, it will perform the conversion into the temporary location to store 
the converted QCOW2 disks of the virtual machine. The disks are then moved into 
the destination storage pools for the virtual machine. The conversion is a 
long-lasting process which can be set to time out by the global setting 
'convert.vmware.instance.to.kvm.timeout'. The conversion processes takes a long 
time because virt-v2v creates a temporary virtual machine to inspect the source 
VM and generate the converted disks with the correct drivers. Additionally, it 
needs to copy the converted disks into the temporary location.
+When importing a instance from VMware to KVM, CloudStack performs the 
following actions:
+
+    - Clones the Source Instance on the selected VMware Datacenter for running
+    VMs: The source instance will be cloned in the original state for running

Review Comment:
   This is unclear wording - can we somehow reword this?
   If VM is running - WHAT is happening, what do we clone/how/what is the 
end-clone-VM state
   If VM is stopped - same questions
   split into proper number of bullet points pls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to