----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12883/ -----------------------------------------------------------
Review request for cloudstack. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3754 Repository: cloudstack-git Description ------- DNS value in Zone is not getting set in the Network created for the Zone. Due to this the prepare and release calls to the Network Plugins are missing this information for the VMs. see Jira bug https://issues.apache.org/jira/browse/CLOUDSTACK-3754 for additional details. Administrators-MacBook-Pro-7:cloudstack seizadi$ git diff diff --git a/ui/scripts/zoneWizard.js b/ui/scripts/zoneWizard.js index cb92c4e..9885b1d 100755 --- a/ui/scripts/zoneWizard.js +++ b/ui/scripts/zoneWizard.js @@ -3084,7 +3084,9 @@ zoneid: args.data.returnedZone.id, name: 'defaultGuestNetwork', displaytext: 'defaultGuestNetwork', - networkofferingid: args.data.zone.networkOfferingId + networkofferingid: args.data.zone.networkOfferingId, + networkDomain: args.data.returnedZone.domain }; //Advanced zone with SG Diffs ----- Diff: https://reviews.apache.org/r/12883/diff/ Testing ------- Created Basic Network with Wizard and validated with FireFox debugger that value was properly set and validated with CloudMonkey that the defaultGuestNetwork created had the DNS Domain value set. I noted that there are other Ajax calls in UI that createNetwork() and don't set this field, also there is a use case where the zone value can be modified and this value would need to be updated in the attached Networks. So I would not close the Jira bug until those additional cases are fixed in the UI. Thanks, Soheil Eizadi
