-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12838/
-----------------------------------------------------------

Review request for cloudstack and Devdeep Singh.


Bugs: CLOUDSTACK-3488


Repository: cloudstack-git


Description
-------

    CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools 
are not in the right state.

    This issue is reporducible if user adds a primary storage and quickly fires
    listStoragePool API command without waiting for the responce of previous
    createStoragePool API command. So during this period
    (before receiving createStoragePool API resonce), the primary srorage is in
    initialized status and the "scope" of storage is not set.


Diffs
-----

  server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 503a563 

Diff: https://reviews.apache.org/r/12838/diff/


Testing
-------

Tests:
1. Add a primary storage.
2. Quickly fire listStoragePool API command.

Verified that listStoragePool API command is working properly without hitting 
any NPE.


Thanks,

Sanjay Tripathi

Reply via email to