Hi Rajesh, I already fix white-spaces but can't update the diff or create a new diff. Review board says "The file 'plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java' (rcda5711) could not be found in the repository". So I added file to this review request, please check it.
About test cases, I haven't written test files for this patch yet. I already done some tests with this patch below. Please tell me if I have to change something. create new guest network new network is created on XCP with name-label = OVSTunnel+VnetID start new VM on this guest network New virtual router is created and started VM is started successfully on this network with name-label = OVSTunnel+VnetID New bridge is created on OVS, named xapi+ID VM's VIF is plugged to this bridge start second VM on this guest network VM is started successfully on this network with name-label = OVSTunnel+VnetID VM's VIF is plugged to the bridge stop Vms on this network VIFs are unplugged stop Virtual Router on this network VR's VIF is unplugged. destroy Vms on this network Bridge is not destroyed destroy Virtual Router on the network, destroy network Bridge is destroyed Create 2,3,4 guest network new networks are created on XCP with name-label = OVSTunnel+VnetIDs start Vms on these guest networks New bridges are created, VIFs are plugged. start Vms on two XCP host GRE tunnel is created between two hosts Thanks, -- N.g.U.y.e.N.A.n.H.t.U 2013/7/10 Rajesh Battala <rajesh.batt...@citrix.com> > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12445/ > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java<https://reviews.apache.org/r/12445/diff/1/?file=319851#file319851line929> > (Diff > revision 1) > > private synchronized Network setupvSwitchNetwork(Connection conn) { > > 929 > > enableXenServerNetwork(conn, vswitchNw, "vswitch", "vswitch > network"); > > 929 > > enableXenServerNetwork(conn, vswitchNw, "vswitch", > "vswitch network"); > > there are many white space/tabs in java and py files. > > can you please post what kind of testing/test cases executed for this patch. > > > - Rajesh Battala > > On July 10th, 2013, 3:31 p.m. UTC, tuna wrote: > Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. > By tuna. > > *Updated July 10, 2013, 3:31 p.m.* > *Repository: * cloudstack-git > Description > > This patch makes sdn gre work with XCP 1.6. Users still can follow the old > strategy described in this post: > https://cwiki.apache.org/CLOUDSTACK/ovs-tunnel-manager-for-cloudstack.html. > > Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1779 > > Diffs > > - > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > (d6d0523) > - scripts/vm/hypervisor/xenserver/ovstunnel (ddcaa5b) > - scripts/vm/hypervisor/xenserver/xcposs/patch (4d07c76) > - scripts/vm/hypervisor/xenserver/xcpserver/patch (7e92d5a) > - scripts/vm/hypervisor/xenserver/xenserver56/patch (8abd6b2) > - scripts/vm/hypervisor/xenserver/xenserver56fp1/patch (901f6de) > > View Diff <https://reviews.apache.org/r/12445/diff/> > -- N.g.U.y.e.N.A.n.H.t.U
