----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11649/ -----------------------------------------------------------
(Updated July 11, 2013, 7:59 a.m.) Review request for cloudstack and Devdeep Singh. Changes ------- Incorporated all the review comments, please commit it if the patch looks fine. Bugs: CLOUDSTACK-1768 Repository: cloudstack-git Description ------- CLOUDSTACK-1768: Ability to delete Events and Alerts: Delete by a time period is required. Under this improvement, archive/deletion of alerts and events by time period i.e. with startdate and enddate is required. Removed parameter "olderthan" and added new params "startdate" and "enddate" in the following APIs: archiveEvents deleteEvents archiveAlerts deleteAlerts Diffs (updated) ----- api/src/org/apache/cloudstack/api/ApiConstants.java e2857b8 api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java 2a1a47a api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java f03793c api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java 481607c api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java a03e6d9 engine/schema/src/com/cloud/alert/dao/AlertDao.java fda814d engine/schema/src/com/cloud/alert/dao/AlertDaoImpl.java 18115a5 engine/schema/src/com/cloud/event/dao/EventDao.java 9454ce7 engine/schema/src/com/cloud/event/dao/EventDaoImpl.java cefe107 server/src/com/cloud/api/ApiDispatcher.java b7d08e2 server/src/com/cloud/server/ManagementServerImpl.java da9d6a2 server/test/com/cloud/alert/AlertControlsUnitTest.java c1e4c54 server/test/com/cloud/event/EventControlsUnitTest.java e2a86cd Diff: https://reviews.apache.org/r/11649/diff/ Testing ------- Tested and verified the result of all the four APIs with the different combinations and inputs of startdate and enddate in my local CloudStack setup. Thanks, Sanjay Tripathi
