> On July 9, 2013, 6:41 p.m., Chip Childers wrote: > > Getting this error after applying to master: > > > > Tests in error: > > > > testConfigDnsMasq(com.cloud.network.router.VpcVirtualNetworkApplianceManagerImplTest): > > Failed to load ApplicationContext
FWIW, outside of the test failure this looks good to me. - Chip ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12327/#review22926 ----------------------------------------------------------- On July 9, 2013, 6:38 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12327/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 6:38 p.m.) > > > Review request for cloudstack, Jayapal Reddy, Murali Reddy, and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-3357 > > > Repository: cloudstack-git > > > Description > ------- > > dnsmasq propagation to vpc routervm > > > Diffs > ----- > > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > ddfa998 > > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java > 7115499 > > server/test/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12327/diff/ > > > Testing > ------- > > a bassc unit test > manual creation of vpc with a networkdomain > > > Thanks, > > daan Hoogland > >
