----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12273/#review22898 -----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/12273/#comment46646> This for loop is not exhaustively taking care of all overlap conditions. server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/12273/#comment46644> It is possible that only a part of the VLAN range may pre-exist here. Minor note: newVnetRangeString String in variable name is sort of redundant. server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/12273/#comment46645> newEndVnet+1 >= existingStartVnet is equivalent to newEndVnet > existingStartVnet server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/12273/#comment46647> Why initialize two diff variables with similar values ? - Abhinandan Prateek On July 5, 2013, 5:35 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12273/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 5:35 a.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: Cloudstack-2150 and Cloudstack-2980 > > > Repository: cloudstack-git > > > Description > ------- > > Cloudstack-2150 DB table entries of phisical network is not proper.Shows > Duplicate entries Cloudstack-2980 Adding a > VLAN range that overlaps with two existing ranges results inconsistent DB > entries > This fix was causing a regression due to which the state of the physical > network was not getting updated and as a result basic zone deployment failed. > Resubmitting the fixed code. > > > Diffs > ----- > > engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 > server/src/com/cloud/network/NetworkServiceImpl.java f88f600 > > Diff: https://reviews.apache.org/r/12273/diff/ > > > Testing > ------- > > Tested > basic zone deployment. > adding vlan > removing vlan > removing all vlan > checked if all the added vlans are in the db. > > > Thanks, > > bharat kumar > >
