----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12323/#review22893 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12323/#comment46639> This should have more meaningful values. I think we spoke about it, probably using enums ? - Abhinandan Prateek On July 9, 2013, 5:35 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12323/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 5:35 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy. > > > Bugs: Cloudstack-32141 > > > Repository: cloudstack-git > > > Description > ------- > > Cloudstack-4241 Adding ip range fails if there are two IP ranges existing in > two different CIDRs > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1c973b8 > > Diff: https://reviews.apache.org/r/12323/diff/ > > > Testing > ------- > > Tested on master-stable > > > Thanks, > > bharat kumar > >
