My apology for sending review request in HTML format... How can I change this behavior of Review Board? (Is there setting?)
-- Toshiaki From: Toshiaki Hatano [mailto:nore...@reviews.apache.org] On Behalf Of Toshiaki Hatano Sent: Friday, July 05, 2013 14:15 To: Hugo Trippaers; Sheng Yang; Chiradeep Vittal; Alena Prokharchyk; Murali Reddy Cc: cloudstack; Toshiaki Hatano Subject: Review Request 12278: CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'. This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12278/ Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang. By Toshiaki Hatano. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384 Repository: cloudstack-git Description CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'. There're VLAN range check code in com.cloud.network.NetworkServiceImpl. But it allows VLAN range between 0-4096. VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) . CloudStack should return error when someone try to assign VLAN ID 4096 to network. Testing Trying to create zone with Guest VLAN range 4090-4096 from WebUI. updatePhysicalNetwork returns error correctly. Diffs • server/src/com/cloud/network/NetworkServiceImpl.java (05df742) View Diff This email message is intended for the use of the person to whom it has been sent, and may contain information that is confidential or legally protected. If you are not the intended recipient or have received this message in error, you are not authorized to copy, distribute, or otherwise use this message or its attachments. Please notify the sender immediately by return e-mail and permanently delete this message and any attachments. Verio Inc. makes no warranty that this email is error or virus free. Thank you.
