On Wed, Jul 03, 2013 at 02:14:59PM +0000, Murali Reddy wrote: > On 02/07/13 7:45 PM, "Ryan Dietrich" <r...@betterservers.com> wrote: > > >Patch submitted. > > > >https://reviews.apache.org/r/12223/ > > Thanks for the patch. Added some comments to the review. Cloudstack group > is missing as reviewer, don't have permission to edit the review, so could > you please add group to the reviewers?
Done > > > > >Things that still need to be thought through: > > > >1. Should the async command event type be a column on async job (and be > >an attribute of AsyncJobVO)? > >2. Should getInstanceId and getInstanceType of AsyncCmd be abstract > >instead of implemented with null values? (would require updating every > >async command in the system, and would break everyones async plugin > >commands) > > > >Oh, and after figuring out how the parameter annotation works (and > >ApiDispatcher uses reflection to iterate over parameters, ugh), I saw > >BaseCmd.java has a HashMap<String, String> of the arguments passed in > >from the user. > >I went with the APIDBUtils query function for UUID's because I saw no > >precedent for accessing that HashMap after initial argument handling. > > > >-Ryan Dietrich > > >
