I checked it into tools/eclipse/eclipse.epf. On Saving a file, it performs the following actions: - reorganizes imports to the following order: java, javax, org. com, org.apache.cloudstack. com.cloud. This places all of the CloudStack imports at the bottom of the import list. - Removes all trailing white space - Removes unused imports - Reformats the EDITED portions of the file using the formatting rules.
It also enforces space for indent. --Alex > -----Original Message----- > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] > Sent: Tuesday, July 2, 2013 8:05 PM > To: dev@cloudstack.apache.org > Subject: RE: Coding Convention Reminder > > +1. Please check-in the preferences file. > > > -----Original Message----- > > From: Vijayendra Bhamidipati > > [mailto:vijayendra.bhamidip...@citrix.com] > > Sent: Wednesday, July 3, 2013 5:58 AM > > To: dev@cloudstack.apache.org > > Subject: RE: Coding Convention Reminder > > > > +1 to checking in the epf file to source, will be good to have it as a > > +reference > > for those using other IDEs as well. > > > > Regards, > > Vijay > > > > -----Original Message----- > > From: Min Chen [mailto:min.c...@citrix.com] > > Sent: Tuesday, July 02, 2013 5:21 PM > > To: dev@cloudstack.apache.org > > Subject: Re: Coding Convention Reminder > > > > +1. It is better to check in your eclipse.eps into git repo, so > > +anybody > > who checked out the CloudStack can access the preference file. > > > > -min > > > > On 7/2/13 5:17 PM, "Prachi Damle" <prachi.da...@citrix.com> wrote: > > > > >+ 1 > > >Please upload the code template for reference. > > > > > >-----Original Message----- > > >From: Edison Su [mailto:edison...@citrix.com] > > >Sent: Tuesday, July 02, 2013 5:08 PM > > >To: dev@cloudstack.apache.org > > >Subject: RE: Coding Convention Reminder > > > > > >We'd better export the code template from Eclipse, then everybody can > > >import the template into their IDE, then possible, everybody will > > >have the same configuration. > > > > > >> -----Original Message----- > > >> From: Alex Huang [mailto:alex.hu...@citrix.com] > > >> Sent: Tuesday, July 02, 2013 3:11 PM > > >> To: dev@cloudstack.apache.org > > >> Subject: Coding Convention Reminder > > >> > > >> I like to remind everyone to review our coding conventions. Our > > >>coding conventions have been going all over the place recently. > > >>Please take a look. > > >> > > >> > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+convent > > >> i > > >> ons > > >> > > >> I also like to propose that we extend the 120 column limit to 180 > > >>columns. > > >> > > >> I recently was reading the following code. If it followed even our > > >> current coding conventions, this would have been 11 lines but it > > >> ends up to be 23 lines, more than doubled. The whole file was like this. > > >> Just thinking about all the extra scrolling I have to do makes my > > >> cts act up. We are in the 21st century and using wide screen lcd > > >> monitors. Let's not format our code to fit > > >> 80 column amber text screens please! > > >> > > >> What's worse is I've found that some people are actively breaking > > >>existing source code to 80 columns, causing a bunch of unnecessary > > >>merge activities. > > >> On Eclipse, you can actually set all types of formatting rules. I > > >>can send out my epf (eclipse preferences file) if you don't want to > > >>deal with the trouble. > > >> DiskOfferingVO diskOffering = > > >>_diskOfferingDao > > >> .findById(vol.getDiskOfferingId()); > > >> if (diskOffering.getUseLocalStorage()) { > > >> if (s_logger.isDebugEnabled()) { > > >> s_logger.debug("Local volume " > > >> + vol > > >> + " will be recreated > > >>on storage pool " > > >> + assignedPool > > >> + " assigned by > > >>deploymentPlanner"); > > >> } > > >> VolumeTask task = new > > >>VolumeTask(VolumeTaskType.RECREATE, vol, null); > > >> tasks.add(task); > > >> } else { > > >> if (s_logger.isDebugEnabled()) { > > >> s_logger.debug("Shared volume " > > >> + vol > > >> + " will be migrated on > > >>storage pool " > > >> + assignedPool > > >> + " assigned by > > >>deploymentPlanner"); > > >> } > > >> VolumeTask task = new > > >>VolumeTask(VolumeTaskType.MIGRATE, vol, assignedPool); > > >> tasks.add(task); > > >> } > > >> > > >> Please be mindful of my cts. Thanks for caring about my health! > > >> :) > > >> > > >> --Alex
