Hi Sateesh, For this patch https://reviews.apache.org/r/12158/ it is dependent on https://reviews.apache.org/r/11992/ . It is already committed by Edison in 4.2 only.
Thanks Rajesh Battala > -----Original Message----- > From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] > Sent: Tuesday, July 2, 2013 8:55 PM > To: Sateesh Chodapuneedi; Ram Ganesh; Edison Su > Cc: cloudstack > Subject: RE: Review Request 12227: NPE wile deployVM in kvm due to > capacityIops > > The issue is that, this patch is dependent on the review > https://reviews.apache.org/r/12158/ . > I had kept that dependency while creating the review request. > First this patch should be committed https://reviews.apache.org/r/12158/ > and then the current patch. > > Thanks > Rajesh Battala > > From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On > Behalf Of Sateesh Chodapuneedi > Sent: Tuesday, July 2, 2013 8:49 PM > To: Ram Ganesh; Sateesh Chodapuneedi; Edison Su > Cc: Rajesh Battala; cloudstack > Subject: Re: Review Request 12227: NPE wile deployVM in kvm due to > capacityIops > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12227/ > > > > > Rajesh, > > Can you re-upload patch again. > > Diff is showing following error. > > ----- > > Diff revision 1 (Latest) > > Files Changed: > > server/src/com/cloud/storage/StorageManagerImpl.java:Diff currently > unavailable. > > > > > - Sateesh Chodapuneedi > > > On July 2nd, 2013, 6:48 a.m. UTC, Rajesh Battala wrote: > Review request for cloudstack, edison su, Ram Ganesh, and Sateesh > Chodapuneedi. > By Rajesh Battala. > > Updated July 2, 2013, 6:48 a.m. > Bugs: 3301 > Repository: cloudstack-git > Description > > Issue: > > When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring. > > > > Fixed: > > SolidFire storage had introduced iops, its setting capacityIops on the pool > level. Only solidfire is setting and getting it which is causing NPE when > checking this value for other type PS. > > This fixed will resolve the issue for any storage provider which don't set > capacityIops. > > > Testing > > 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed. > > 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully. > > > Diffs > > * server/src/com/cloud/storage/StorageManagerImpl.java (8401b77) > > View Diff<https://reviews.apache.org/r/12227/diff/> >
