----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12028/#review22481 -----------------------------------------------------------
Commit 0d788681809f720f8ad55eb27c995d7f09ed7106 in branch refs/heads/master from Saksham Srivastava [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0d78868 ] CLOUDSTACK-3064: Able to create an instance from different account of the same domain without using affinity group even if the zone is dedicated to an account. The check to make sure that explicit resources are not picked up for non-explicit deployment was present only at the domain level for zones. Added a check at account level too. - ASF Subversion and Git Services On June 21, 2013, 2:09 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12028/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 2:09 p.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: 3064 > > > Repository: cloudstack-git > > > Description > ------- > > When a zone is dedicated to an account, other accounts should not be able to > deploy vms on that zone. > Also if no explicit dedication type affinity group is chosen, vm deployment > from the same account should fail. > > > Diffs > ----- > > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 4ef2152 > > Diff: https://reviews.apache.org/r/12028/diff/ > > > Testing > ------- > > Tested dedicating zone, then deploying vms from other accounts, it fails now. > Also if no affinity group is chosen for the same account, vm deployment fails. > > > Thanks, > > Saksham Srivastava > >