> On June 26, 2013, 6:20 p.m., David Nalley wrote: > > Despite different descriptions, 12105 and 12106 appear to be the same patch.
They're different. 12106's patch was generated by post-review. By default, post-review included patches submitted in 12106, 12105, 12103, and 12085, because their changes were not added to Master. I can moved the comments from 12105, 12103, and 12085 to 12106, and close the earlier Review Board submissions. - Donal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12106/#review22411 ----------------------------------------------------------- On June 26, 2013, 6:15 p.m., Donal Lafferty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12106/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 6:15 p.m.) > > > Review request for cloudstack, Alex Huang, Chip Childers, and edison su. > > > Repository: cloudstack-git > > > Description > ------- > > Add Hyperv-V support to ListHypervisorsCmd API call > > > Diffs > ----- > > agent/src/com/cloud/agent/VmmAgentShell.java > 190d1168284243f9e860677a03311da9db31c745 > api/src/com/cloud/storage/Storage.java > 9a50ffa786c9a1b516baa7b8bce04de7d3c7b2bc > client/tomcatconf/applicationContext.xml.in > ac1f3e46fdb43b4a5e38f9f2b3c498a2c258a0aa > core/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java > 725f0cc1ae214447f20f5cd51c40e7e9128f0506 > engine/storage/integration-test/test/resource/component.xml > 5ba87e8ebe9a682b320c60caf0e0057d2eb92027 > plugins/network-elements/dns-notifier/resources/components-example.xml > 717c5e063fe0271eeb1143215a493c6342c5811e > server/src/com/cloud/configuration/Config.java > ba508495c350714fff90da0923b046783d42b1c3 > server/src/com/cloud/hypervisor/guru/HypervGuru.java > 630080e21cbb6a501d67bda41179feb278b3d79c > server/src/com/cloud/hypervisor/hyperv/HypervServerDiscoverer.java > 06658b7f3e2ea5e80edf012dcaf29d980758084d > server/src/com/cloud/resource/ResourceManagerImpl.java > fe91cb337d0f5901012ca45e131d9cb2f7c54cf2 > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > 954c7e970f02e7ba0eae6e8e1616d9a08c9168b0 > > Diff: https://reviews.apache.org/r/12106/diff/ > > > Testing > ------- > > Compiled using mvn clean install, used in integration test on cshv3 branch > from github mirror. > > > Thanks, > > Donal Lafferty > >
