I've started in on making Wei's feature and mine mutually exclusive. We had talked about using radio buttons to do this in the GUI, but I don't see radio buttons in use at present in the CS GUI.
Instead, I'm following the current paradigm in the GUI where a combo box presents options to accomplish this. If you select the empty option, you get neither Wei's fields nor mine. If you select 'hypervisor', you get Wei's fields. If you select 'storage', you get mine. The combo box has the name 'QoS Type' and has a tool tip. This technique is working well and fits in nicely with how a similar selection process happens on the Add Volume dialog via a combo box. I don't have all of the code written at present, but it should be done tomorrow (well...technically later today). Talk to you later! On Tue, Jun 18, 2013 at 6:05 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> wrote: > OK, I've gone ahead and updated Review Board with a new diff. > > Please check it out and let me know what you think. > > Thanks! > > > On Mon, Jun 17, 2013 at 2:52 PM, Mike Tutkowski < > mike.tutkow...@solidfire.com> wrote: > >> Sounds good >> >> I have a little bit of clean-up work to do and then I must figure out how >> to generate a patch (since I was using merge rather than rebase during >> development), so it will probably be tomorrow. >> >> >> On Mon, Jun 17, 2013 at 2:50 PM, John Burwell <jburw...@basho.com> wrote: >> >>> Mike, >>> >>> Great news. Let me know when Review Board is updated, and I will >>> perform a second round review. >>> >>> Thanks, >>> -John >>> >>> On Jun 17, 2013, at 4:48 PM, Mike Tutkowski < >>> mike.tutkow...@solidfire.com> wrote: >>> >>> > FYI: I added the IOPS-capacity parameter and related code over the >>> weekend. >>> > >>> > The final bit of work for me comes when Wei's code is merged into >>> master >>> > and I pull it down. >>> > >>> > At that point, I need to add the GUI and API logic to support mutual >>> > exclusion of our features. >>> > >>> > >>> > On Sat, Jun 15, 2013 at 11:12 AM, Chip Childers >>> > <chip.child...@sungard.com>wrote: >>> > >>> >> On Fri, Jun 14, 2013 at 05:56:27PM -0400, John Burwell wrote: >>> >>> Mike, >>> >>> >>> >>> Awesome. +1. >>> >>> >>> >>> Thanks for your patience with the back and forth, >>> >>> -John >>> >> >>> >> +1 - this now looks like a great approach. >>> >> >>> > >>> > >>> > >>> > -- >>> > *Mike Tutkowski* >>> > *Senior CloudStack Developer, SolidFire Inc.* >>> > e: mike.tutkow...@solidfire.com >>> > o: 303.746.7302 >>> > Advancing the way the world uses the >>> > cloud<http://solidfire.com/solution/overview/?video=play> >>> > *™* >>> >>> >> >> >> -- >> *Mike Tutkowski* >> *Senior CloudStack Developer, SolidFire Inc.* >> e: mike.tutkow...@solidfire.com >> o: 303.746.7302 >> Advancing the way the world uses the >> cloud<http://solidfire.com/solution/overview/?video=play> >> *™* >> > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the > cloud<http://solidfire.com/solution/overview/?video=play> > *™* > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *™*
