> On June 17, 2013, 6:44 p.m., Chip Childers wrote: > > Wei, > > > > Should this still be applied? If so, can you go ahead and do it (remember, > > 4.0 is not going to see another non-security release). > > > > If not, can you please close this review? > > > > -chip
Chip, I just changed and committed it. Thanks. -Wei - Wei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10062/#review22007 ----------------------------------------------------------- On March 22, 2013, 6:22 a.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10062/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 6:22 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > The return value of listByStateAndNetworkType function in > server/src/com/cloud/vm/dao/DomainRouterDaoImpl.java contains duplicated VPC > router. > For example, if a VPC contains 3 tiers, the return value contains 3 VPC > routers. > > We need to get only one VPC router for a VPC. > > This patch applies on 4.0.1. I will create a patch for master/4.1 later. > > > Diffs > ----- > > server/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 175d3f2 > > Diff: https://reviews.apache.org/r/10062/diff/ > > > Testing > ------- > > Testing manually ok. > > > Thanks, > > Wei Zhou > >
