----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11909/#review21981 -----------------------------------------------------------
Ship it! Applied but the test will fail because of a regression in the NetworkACL code. Details in CLOUDSTACK-2915 - Prasanna Santhanam On June 17, 2013, 2:03 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11909/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 2:03 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > ------- > > Corrected code related to cleanup of VPC offering. self.vpc_off was added > twice instead of vpc_off. That may lead to error in the cleanup process > eventually leading to accounts and vpc offerings not being cleaned up. > > > Diffs > ----- > > test/integration/component/test_vpc_network_lbrules.py 66d6c4d > test/integration/component/test_vpc_network_pfrules.py 92b04ad > > Diff: https://reviews.apache.org/r/11909/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
