Daan, Since a WARN indicates a condition that could lead to system instability, many folks configure their log analysis to trigger notifications on WARN and INFO. Does escaping a character in a path warrant meet that criteria?
Thanks, -John On Jun 14, 2013, at 11:52 AM, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > H John, > > I browsed through your comments and most I will apply. There is one where > you contradict Hiroaki. This is about the logging level for reporting a > changed path. I am going to follow my heart at this unless there is a > project directive on it. > > regards, > Daan > > > On Fri, Jun 14, 2013 at 5:25 PM, John Burwell <jburw...@basho.com> wrote: > >> Daan, >> >> I just looked through the review request, and published my comments. >> >> Thanks, >> -John >> >> On Jun 14, 2013, at 10:27 AM, Daan Hoogland <daan.hoogl...@gmail.com> >> wrote: >> >>> Hiroaki, >>> >>> - auto-fix may happen where it is really required >>>> >>> I do not have a clear view on this, so I took the approach of better safe >>> then sorry. The submitted is what works. I don't see how the auto-fix >>> should ever be needed if the source is fixed. Hope you can live with >> this. >>> >>>> - and if auto-fix happens, it should log it with >>>> WARN level. >>> >>> Applied >>> >>> >>> regards, >>> >>> >>> On Fri, Jun 14, 2013 at 10:35 AM, Daan Hoogland <daan.hoogl...@gmail.com >>> wrote: >>> >>>> Thanks Hiroaki, >>>> >>>> On Fri, Jun 14, 2013 at 3:41 AM, Hiroaki KAWAI < >> ka...@stratosphere.co.jp>wrote: >>>> >>>>> I'd suggest: >>>>> - fix the generation of double slash itself >>>>> >>>> Is in the patch >>>> >>>>> - auto-fix may happen where it is really required >>>>> - and if auto-fix happens, it should log it with >>>>> WARN level. >>>> >>>> Good point, I will up the level in an update. >>>> >>>>> >>>>> >>>>> >>>>> (2013/06/13 21:15), Daan Hoogland wrote: >>>>> >>>>>> H, >>>>>> >>>>>> Can someone look at Review Request #11861<https://reviews.apache.** >>>>>> org/r/11861/ <https://reviews.apache.org/r/11861/>> for me please? >>>>>> >>>>>> Thanks, >>>>>> Daan Hoogland >>>>>> >>>>>> >>>>> >>>> >> >>
