Wei, I published my review. I didn't see any code to validating the rate values (e.g. values greater than 0, values less than an maximum value). Did I miss it?
I also noticed that 0 is being used when no value has been specified. I recommend using the Long type rather primitive long in order to use null to represent unspecified values rather than a magic value. Thanks, -John On Jun 13, 2013, at 11:34 AM, Wei ZHOU <ustcweiz...@gmail.com> wrote: > John, > > Please review the code on https://reviews.apache.org/r/11782 > The storage provisioned IOPS does not affect hypervisor throttled I/O, I > think. > Mike may change UI and java code for storage provisioned IOPS after the > merge. > > -Wei > > > 2013/6/13 John Burwell <jburw...@basho.com> > >> Wei, >> >> There are open questions on the thread regarding mutual exclusion of >> hypervisor throttled I/O and storage provisioned IOPS. We need to >> understand how and where it will be implemented in both the UI and >> service layers. Also, can you resend the Review Board review? My >> email search skills have failed to find it. >> >> Thanks, >> -John >> >>
