On Thu, Jun 13, 2013 at 05:10:06PM +0000, Rajesh Battala wrote: > Hi All, > While fixing an issue ( https://reviews.apache.org/r/11862/ )in ssvm-check > script I figured out some issues. > > 1.There are two ssvm_check scripts(duplicates). > > ./services/console-proxy/server/scripts/ssvm-check.sh > ./services/secondary-storage/scripts/ssvm-check.sh > > When building the code, these scripts will go to systemvm.zip, systemvm.zip > will be packaged into systemvm.iso. > > systemvm-descriptor.xml will define what all the scripts should package. > As per the descriptor xml, the ssvm-check script under console-proxy is > getting into systemvm.zip. > > I had verified the ssvm-check script with the fix under console-proxy. The > systemvm.zip is getting update properly and making into systemvm.iso. > And ssvm is getting the right script now. > > Changes made in script under > ./services/secondary-storage/scripts/ssvm-check.sh is not getting into > systemvm.iso > > I feel the script is redundant and creating confusion. > Can we remove the script in one location? > > Thanks > Rajesh Battala
This seems quite logical. Care to submit a patch that cleans this up?
