----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11782/#review21754 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java <https://reviews.apache.org/r/11782/#comment44947> Any reason this is commented? Or just a small mistake? plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java <https://reviews.apache.org/r/11782/#comment44950> Isn't there a way to get this information via the libvirt-java API? If not, what are you missing? I'm not a big fan of these constructions. http://libvirt.org/sources/java/javadoc/org/libvirt/Connect.html Wouldn't these methods help you? * getCapabilities() * getHypervisorVersion(java.lang.String type) * getLibVirVersion() * getVersion() server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11782/#comment44945> Why is this warn and nog debug? Also, couldn't you extend these lines a bit more? Since a non-developer would never get what you mean with this. - Wido den Hollander On June 10, 2013, 5:51 p.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11782/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 5:51 p.m.) > > > Review request for cloudstack, Wido den Hollander and John Burwell. > > > Description > ------- > > The patch for VM Disk I/O throttling based on commit > 3f3c6aa35f64c4129c203d54840524e6aa2c4621 > > > This addresses bug CLOUDSTACK-1301. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/VolumeTO.java 4cbe82b > api/src/com/cloud/offering/DiskOffering.java dd77c70 > api/src/com/cloud/vm/DiskProfile.java e3a3386 > api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c > > api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java > aa11599 > > api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java > 4c54a4e > api/src/org/apache/cloudstack/api/response/DiskOfferingResponse.java > 377e66e > api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java > 31533f8 > api/src/org/apache/cloudstack/api/response/VolumeResponse.java 21d7d1a > client/WEB-INF/classes/resources/messages.properties 2b17359 > core/src/com/cloud/agent/api/AttachVolumeCommand.java 302b8f8 > engine/schema/src/com/cloud/storage/DiskOfferingVO.java 909d7fe > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > bab53bc > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java > b8645e1 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java > 9cddb2e > server/src/com/cloud/api/query/dao/DiskOfferingJoinDaoImpl.java 283181f > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 56e4d0a > server/src/com/cloud/api/query/dao/VolumeJoinDaoImpl.java e27e2d9 > server/src/com/cloud/api/query/vo/DiskOfferingJoinVO.java 6d3cdcb > server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java e87a101 > server/src/com/cloud/api/query/vo/VolumeJoinVO.java 6ef8c91 > server/src/com/cloud/configuration/Config.java 5ee0fad > server/src/com/cloud/configuration/ConfigurationManager.java 8db037b > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/storage/StorageManager.java d49a7f8 > server/src/com/cloud/storage/StorageManagerImpl.java d38b35e > server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681 > server/src/com/cloud/test/DatabaseConfig.java 70c8178 > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 21b3590 > setup/db/db/schema-410to420.sql bcfbcc9 > ui/dictionary.jsp a5f0662 > ui/scripts/configuration.js cb15598 > ui/scripts/instances.js 7149815 > > Diff: https://reviews.apache.org/r/11782/diff/ > > > Testing > ------- > > testing ok. > > > Thanks, > > Wei Zhou > >
