----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11563/#review21234 -----------------------------------------------------------
Ship it! Ship It! - Prasanna Santhanam On May 31, 2013, 1:13 a.m., Laszlo Hornyak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11563/ > ----------------------------------------------------------- > > (Updated May 31, 2013, 1:13 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > ConfigurationServerImpl.getBase64Keystore did not close the file input stream > correctly. This patch adds test and replaces the file read with commons-io > FileUtils call. > > > Diffs > ----- > > server/pom.xml 6385bf2 > server/src/com/cloud/server/ConfigurationServerImpl.java 35f977b > server/test/com/cloud/server/ConfigurationServerImplTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/11563/diff/ > > > Testing > ------- > > test included > > > Thanks, > > Laszlo Hornyak > >
