----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11380/#review21212 -----------------------------------------------------------
Commit 8ece25c1f2bd6d0126c2a22b42e1c4da65fc2856 in branch refs/heads/master from Jessica Wang <jessicaw...@apache.org> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ece25c ] CLOUDSTACK-681: deployment planner - create compute offering dialog - deployment planner dropdown - add blank option and make it as default option. Not pass anything to API call when blank option is selected. - ASF Subversion and Git Services On May 30, 2013, 7:23 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11380/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 7:23 a.m.) > > > Review request for cloudstack, Devdeep Singh and Prachi Damle. > > > Description > ------- > > Patch 2 for https://reviews.apache.org/r/11379/ > Created for files > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java, > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java, > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java > > > This addresses bug CLOUDSTACK-681. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 79375f9 > server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java 795b526 > server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java e3b7d31 > server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 24c5d3d > > Diff: https://reviews.apache.org/r/11380/diff/ > > > Testing > ------- > > Unittest: For the new APIs and Service, added unit tests under : > plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java > Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm > is deployed on the dedicated host. > Rat Build Successful. > > > Thanks, > > Saksham Srivastava > >
