----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21095 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment43722> this code was there earlier i just reused it. But seems like a valid concern will put this in a transaction. server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11435/#comment43743> This type of code can be found at other places in cloudstack . I dont know why was it done this way and don't know what will be the implications if i change it. so i reused the same code. - bharat kumar On May 27, 2013, 2:50 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 2:50 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 214e292 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > b969be2 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
