> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 360 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line360> > > > > create_vm with pf=true has been implemented?
Yes, VirtualMachine.create() checks for mode if mode is 'advance' it crate pf rule else it does not. > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 370 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line370> > > > > If a VM with attached volumes is moved then the VM along with the > > volumes will be successfully moved to the new owner. Sure I will add check for volume > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 382 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line382> > > > > When a VM is moved the snapshots of the attached volumes is deleted and > > the move is successful. In this test case we are testing for VM ownership change for VM with root disk snapshot not volumes are attached. > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 322 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line322> > > > > How is this test different from test_07? Yes target account should not have any default network and network should get crated once vm ownership is changed, I need to add assert for network created in target account. > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 404 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line404> > > > > In this test case we are setting the limit on the number of VM's that > > can be in subdomain1 to 1. > > Haven't we already moved a number of VMs to subdomain1 that are yet to > > cleaned up? for a test run only 1 vm is created and destroyed after test run is complete not test suite. limit resource type is snapshot > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 424 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line424> > > > > Same concern as above. > > Also, can you specify for what resource the account limit has been > > reached? If it is VM how is it different from test_16? for this test run limit resource type is snapshot. pre conditions are volumes attached to a vm and limit is reached. > On May 28, 2013, 8:22 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 322 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line322> > > > > How is this test case different from test_07 here we only check for vm ownership change. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11307/#review21077 ----------------------------------------------------------- On May 28, 2013, 8:28 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11307/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 8:28 a.m.) > > > Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth > Jagirdar, and Girish Shilamkar. > > > Description > ------- > > Testcases for changing account membership for vas > > > This addresses bug CLOUDSTACK-2273. > > > Diffs > ----- > > test/integration/component/test_assign_vm.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py f3a96bd > > Diff: https://reviews.apache.org/r/11307/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
