On Sun, May 26, 2013 at 12:00:19PM +0200, Wido den Hollander wrote: > Hi Chip, > > I'm sorry, but I'm going to have to vote -1 on this one. > > It's my bad, but it seems that I made a mistake on the Debian > packaging side. See this commit: > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=dc822a83d77830281402175b4a57b25b7e3b180a > > I just verified, cloudstack-setup-agent has variables in it like > @AGENTSYSCONFDIR@ which would render the tool useless. > > I see this commit is already in the 4.1 branch, but it isn't in the > commit you are voting on (873c19). > > I also found a problem with the AWSAPI package, which is in master > in commit 28f7a216d8bf4da29a45cb76e5c28ee568ae1984 > > I already cherry-picked that one to 4.1 since it's only touching > packaging and not code. > > Other then the packaging I'm happy with this code. I obviously > wasn't able to do a full QA on my own, but the tests I've done all > work, which include: > * Deploying instances > * Adding RBD storage > * Attaching RBD volumes > > With the packaging resolved I'd vote +1, but for now it's -1 (binding). > > Wido
I got myself to my laptop. I see that these corrections are in 4.1 now. I'll respin a release candidate right now.
