> On April 1, 2013, 7:41 a.m., Koushik Das wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3884 > > <https://reviews.apache.org/r/9779/diff/1/?file=267170#file267170line3884> > > > > Handling of iso case is not clear. Are you expecting the iso id in the > > newTemplateId parameter?
Now we have common API parameter id that takes either template ID or ISO ID. So in the restoreVMInternal method "newTemplateId" can be either template/ISO id, we handle it accordingly in the code. - Harikrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9779/#review18578 ----------------------------------------------------------- On May 24, 2013, 5:52 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9779/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 5:52 a.m.) > > > Review request for cloudstack, Nitin Mehta and Koushik Das. > > > Description > ------- > > CLOUDSTACK-1453: support restore for VM created from ISO > Previously this was not there. Fixed with small changes > > > This addresses bug CLOUDSTACK-1453. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java 9c33f97 > server/src/com/cloud/vm/UserVmManagerImpl.java a3b731a > server/test/com/cloud/vm/UserVmManagerTest.java 6a97114 > > Diff: https://reviews.apache.org/r/9779/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Harikrishna Patnala > >
