-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11277/#review20951
-----------------------------------------------------------


My first note of a quick scan of the code is that the whitespacing should be 
checked.

There are cases where tabs were used and also lines with trailing whitespace or 
even blank lines with spaces in them.

- Wido den Hollander


On May 20, 2013, 10:12 p.m., edison su wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11277/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 10:12 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> The diff generated by: git diff master..object_store
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/Answer.java 655f447 
>   api/src/com/cloud/agent/api/storage/CopyTemplateToPrimaryStorageAnswer.java 
> PRE-CREATION 
>   api/src/com/cloud/agent/api/storage/PasswordAuth.java PRE-CREATION 
>   api/src/com/cloud/agent/api/storage/Proxy.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/DataObjectType.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/DataStoreTO.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/DataTO.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/DiskTO.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/NfsTO.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/S3TO.java d556cb6 
>   api/src/com/cloud/agent/api/to/SwiftTO.java 32742c7 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java b84d20a 
>   api/src/com/cloud/resource/ResourceService.java 08e2585 
>   api/src/com/cloud/server/ManagementService.java 2249407 
>   api/src/com/cloud/storage/DataStoreRole.java PRE-CREATION 
>   api/src/com/cloud/storage/GuestOSHypervisor.java PRE-CREATION 
>   api/src/com/cloud/storage/ImageStore.java PRE-CREATION 
>   api/src/com/cloud/storage/ScopeType.java PRE-CREATION 
>   api/src/com/cloud/storage/Snapshot.java f71265c 
>   api/src/com/cloud/storage/StorageService.java 63c5023 
>   api/src/com/cloud/storage/Upload.java ac3836c 
>   api/src/com/cloud/storage/VolumeApiService.java 7e5ebe2 
>   api/src/com/cloud/storage/snapshot/SnapshotApiService.java PRE-CREATION 
>   api/src/com/cloud/storage/snapshot/SnapshotService.java b5325f5 
>   api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
>   api/src/com/cloud/storage/template/TemplateProp.java PRE-CREATION 
>   api/src/com/cloud/template/TemplateApiService.java PRE-CREATION 
>   api/src/com/cloud/template/TemplateService.java 7e831fb 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 33a9171 
>   api/src/org/apache/cloudstack/api/BaseCmd.java 9ac110c 
>   api/src/org/apache/cloudstack/api/ResponseGenerator.java 10bf305 
>   
> api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java
>  f1d12b3 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreCmd.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java 
> dbd9bff 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/CreateCacheStoreCmd.java
>  PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/DeleteImageStoreCmd.java
>  PRE-CREATION 
>   
> api/src/org/apache/cloudstack/api/command/admin/storage/ListImageStoresCmd.java
>  PRE-CREATION 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListS3sCmd.java 
> 4ab71de 
>   api/src/org/apache/cloudstack/api/command/admin/swift/AddSwiftCmd.java 
> 364d916 
>   api/src/org/apache/cloudstack/api/command/admin/swift/ListSwiftsCmd.java 
> 7cfe6e1 
>   
> api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
>  7d41d10 
>   api/src/org/apache/cloudstack/api/command/user/iso/ExtractIsoCmd.java 
> 08a15ee 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java f872c12 
>   api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 
> 284d553 
>   api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoCmd.java 
> 37294e3 
>   
> api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java
>  0b33f56 
>   
> api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java 
> a4f0582 
>   
> api/src/org/apache/cloudstack/api/command/user/template/ExtractTemplateCmd.java
>  9a2dee3 
>   
> api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java 
> f0fc241 
>   
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java
>  c9da0c2 
>   
> api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java
>  3987dbe 
>   api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java 
> 86a494b 
>   api/src/org/apache/cloudstack/api/response/ImageStoreDetailResponse.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/api/response/ImageStoreResponse.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a 
>   api/src/org/apache/cloudstack/api/response/TemplateZoneResponse.java 
> PRE-CREATION 
>   api/src/org/apache/cloudstack/query/QueryService.java 2dfd97c 
>   
> api/test/org/apache/cloudstack/api/command/test/AddSecondaryStorageCmdTest.java
>  d6de94d 
>   api/test/org/apache/cloudstack/api/command/test/AddSwiftCmdTest.java 
> 141a236 
>   client/pom.xml 197ba27 
>   client/tomcatconf/applicationContext.xml.in 6406660 
>   client/tomcatconf/commands.properties.in f57cc3c 
>   core/src/com/cloud/agent/Listener.java 47b9bc3 
>   core/src/com/cloud/agent/api/DeleteObjectFromSwiftCommand.java 3d62c50 
>   core/src/com/cloud/agent/api/DeleteSnapshotBackupCommand.java 128df84 
>   core/src/com/cloud/agent/api/DeleteTemplateFromS3Command.java 278669b 
>   core/src/com/cloud/agent/api/MigrateWithStorageAnswer.java 06aff32 
>   core/src/com/cloud/agent/api/MigrateWithStorageCompleteAnswer.java 920cf48 
>   core/src/com/cloud/agent/api/ModifyStoragePoolAnswer.java df77985 
>   core/src/com/cloud/agent/api/SecStorageSetupCommand.java 50c06cf 
>   core/src/com/cloud/agent/api/SnapshotCommand.java d8abeb6 
>   core/src/com/cloud/agent/api/StartupStorageCommand.java 3c3b058 
>   core/src/com/cloud/agent/api/storage/AbstractDownloadCommand.java 04b3d43 
>   core/src/com/cloud/agent/api/storage/CopyVolumeAnswer.java 8c55ac3 
>   core/src/com/cloud/agent/api/storage/CreateAnswer.java ab6cc03 
>   core/src/com/cloud/agent/api/storage/CreatePrivateTemplateAnswer.java 
> 83db84d 
>   core/src/com/cloud/agent/api/storage/DeleteTemplateCommand.java 69f465c 
>   core/src/com/cloud/agent/api/storage/DeleteVolumeCommand.java 949af01 
>   core/src/com/cloud/agent/api/storage/DownloadCommand.java c6ffe45 
>   core/src/com/cloud/agent/api/storage/DownloadProgressCommand.java 835847b 
>   core/src/com/cloud/agent/api/storage/ListTemplateAnswer.java a4e2e25 
>   core/src/com/cloud/agent/api/storage/ListTemplateCommand.java da25ed5 
>   core/src/com/cloud/agent/api/storage/ListVolumeAnswer.java 6bbb2e8 
>   core/src/com/cloud/agent/api/storage/ListVolumeCommand.java 63c5b62 
>   core/src/com/cloud/agent/api/storage/ManageVolumeAvailabilityAnswer.java 
> edd2830 
>   core/src/com/cloud/agent/api/storage/PrimaryStorageDownloadAnswer.java 
> a5a6c49 
>   core/src/com/cloud/agent/api/storage/PrimaryStorageDownloadCommand.java 
> 8d955bb 
>   core/src/com/cloud/agent/api/storage/ResizeVolumeAnswer.java 3434b98 
>   core/src/com/cloud/agent/api/storage/UpgradeDiskAnswer.java 9660136 
>   core/src/com/cloud/agent/api/storage/UploadCommand.java 473bd5b 
>   core/src/com/cloud/agent/transport/ArrayTypeAdaptor.java 8eddc03 
>   core/src/com/cloud/agent/transport/InterfaceTypeAdaptor.java PRE-CREATION 
>   core/src/com/cloud/hypervisor/hyperv/resource/HypervResource.java 0f9b3dd 
>   core/src/com/cloud/serializer/GsonHelper.java 8b2dcb0 
>   core/src/com/cloud/storage/GuestOSHypervisorVO.java PRE-CREATION 
>   core/src/com/cloud/storage/resource/StorageProcessor.java PRE-CREATION 
>   core/src/com/cloud/storage/resource/StorageSubsystemCommandHandler.java 
> PRE-CREATION 
>   core/src/com/cloud/storage/resource/StorageSubsystemCommandHandlerBase.java 
> PRE-CREATION 
>   core/src/com/cloud/storage/template/HttpTemplateDownloader.java 628ad64 
>   core/src/com/cloud/storage/template/S3TemplateDownloader.java PRE-CREATION 
>   core/src/com/cloud/storage/template/TemplateConstants.java 5c6de98 
>   core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
>   core/src/org/apache/cloudstack/storage/command/DownloadCommand.java 
> PRE-CREATION 
>   core/src/org/apache/cloudstack/storage/command/DownloadProgressCommand.java 
> PRE-CREATION 
>   core/test/com/cloud/agent/transport/RequestTest.java 64c1e0b 
>   
> core/test/org/apache/cloudstack/api/agent/test/BackupSnapshotCommandTest.java 
> 44d53aa 
>   core/test/org/apache/cloudstack/api/agent/test/SnapshotCommandTest.java 
> c2d69c0 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ClusterScope.java
>  0f0e958 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/CommandResult.java
>  cc45914 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/CopyCommandResult.java
>  571a77c 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/CreateCmdResult.java
>  b6d5b68 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionService.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataObject.java
>  0827cf6 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataObjectInStore.java
>  32ea996 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataObjectType.java
>  b4d1a57 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStore.java
>  f101f24 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreDriver.java
>  cf5759b 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreLifeCycle.java
>  280e02e 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreManager.java
>  15e49e1 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreProvider.java
>  115a52f 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreProviderManager.java
>  906720a 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreRole.java
>  a45ca7a 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPoint.java
>  2ff45b1 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/EndPointSelector.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HostScope.java
>  c5e90ac 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ImageDataFactory.java
>  f0d6988 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ImageDataStoreProvider.java
>  1fb987e 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ImageService.java
>  119f3b1 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ImageStoreProvider.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
>  78a1014 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/Scope.java 
> 91d4734 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ScopeType.java
>  a3d21ce 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotDataFactory.java
>  1ff3ff2 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotInfo.java
>  b90404c 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotResult.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotService.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java
>  e9492c4 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StorageCacheManager.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateDataFactory.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateInfo.java
>  8e03503 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateService.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/VolumeInfo.java
>  349325a 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/VolumeService.java
>  3a1fe6a 
>   
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ZoneScope.java
>  2d3d41f 
>   engine/api/src/org/apache/cloudstack/storage/command/AttachAnswer.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/AttachCommand.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/AttachPrimaryDataStoreAnswer.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/AttachPrimaryDataStoreCmd.java
>  PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/CommandResult.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/CopyCmdAnswer.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/CopyCommand.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/CreateObjectAnswer.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/CreateObjectCommand.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/CreatePrimaryDataStoreCmd.java
>  PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/DeleteCommand.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/DettachAnswer.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/command/DettachCommand.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/DownloadSystemTemplateCommand.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/command/StorageSubSystemCommand.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/DataStoreProviderDao.java
>  dca83ce 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/DataStoreProviderDaoImpl.java
>  ccb6b48 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/DataStoreProviderVO.java
>  dcdafdd 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDao.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailVO.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailsDao.java
>  PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/datastore/db/ImageStoreVO.java 
> PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  4d84525 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  7fcddf1 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDetailsDaoImpl.java
>  59c488c 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDao.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreVO.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 
> 55b2314 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/TemplateDataStoreDao.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/TemplateDataStoreVO.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreDao.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/datastore/db/VolumeDataStoreVO.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreEntity.java
>  PRE-CREATION 
>   
> engine/api/src/org/apache/cloudstack/storage/image/datastore/ImageStoreInfo.java
>  PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/NfsPrimaryDataStoreTO.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/SnapshotObjectTO.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/TemplateObjectTO.java 
> PRE-CREATION 
>   engine/api/src/org/apache/cloudstack/storage/to/VolumeObjectTO.java 
> PRE-CREATION 
>   
> engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/ScopeTest.java
>  e3ec48c 
>   engine/pom.xml 169425a 
>   engine/schema/src/com/cloud/storage/SnapshotVO.java 78b96ec 
>   engine/schema/src/com/cloud/storage/UploadVO.java d761bf1 
>   engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
>   engine/schema/src/com/cloud/storage/VMTemplateStoragePoolVO.java 9b76176 
>   engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 
>   engine/schema/src/com/cloud/storage/VolumeHostVO.java 40bae49 
>   engine/schema/src/com/cloud/storage/dao/SnapshotDao.java 3ac9e77 
>   engine/schema/src/com/cloud/storage/dao/SnapshotDaoImpl.java f55663f 
>   engine/schema/src/com/cloud/storage/dao/UploadDaoImpl.java 31fad43 
>   engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java 8520757 
>   engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 25ae933 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 1bd9abe 
>   engine/storage/backup/pom.xml 019e09c 
>   
> engine/storage/backup/src/org/apache/cloudstack/storage/backup/BackupMotionService.java
>  cb49027 
>   
> engine/storage/backup/src/org/apache/cloudstack/storage/backup/BackupService.java
>  67924d2 
>   engine/storage/cache/pom.xml PRE-CREATION 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheAllocator.java
>  PRE-CREATION 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java
>  PRE-CREATION 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
>  PRE-CREATION 
>   engine/storage/datamotion/pom.xml PRE-CREATION 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  PRE-CREATION 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionDriver.java
>  PRE-CREATION 
>   
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
>  PRE-CREATION 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/ImageDataFactoryImpl.java
>  616e478 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/ImageServiceImpl.java
>  99b1013 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateDataFactoryImpl.java
>  PRE-CREATION 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
>  PRE-CREATION 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/driver/AncientImageDataStoreDriverImpl.java
>  4c16f2f 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/driver/DefaultImageDataStoreDriverImpl.java
>  3d46c73 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/manager/ImageDataManagerImpl.java
>  83e9887 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/manager/ImageDataStoreManagerImpl.java
>  bc546f8 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java
>  PRE-CREATION 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/AncientImageDataStoreProvider.java
>  2715dc7 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/DefaultImageDataStoreImpl.java
>  6eefc6f 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/DefaultImageDataStoreProvider.java
>  0b5de85 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/ImageStoreImpl.java
>  PRE-CREATION 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/TemplateObject.java
>  b6c2004 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/lifecycle/DefaultImageDataStoreLifeCycle.java
>  ba29c1a 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/lifecycle/ImageDataStoreLifeCycle.java
>  a368239 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/store/lifecycle/ImageStoreLifeCycle.java
>  PRE-CREATION 
>   engine/storage/imagemotion/pom.xml 9a7f3e0 
>   
> engine/storage/imagemotion/src/org/apache/cloudstack/storage/image/motion/DefaultImageMotionStrategy.java
>  1c21496 
>   
> engine/storage/imagemotion/src/org/apache/cloudstack/storage/image/motion/ImageMotionServiceImpl.java
>  93ba4a5 
>   
> engine/storage/imagemotion/src/org/apache/cloudstack/storage/image/motion/ImageMotionStrategy.java
>  7a47636 
>   engine/storage/integration-test/pom.xml 1bce37a 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/MockLocalNfsSecondaryStorageResource.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/allocator/StorageAllocatorTest.java
>  9444fa5 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/ChildTestConfiguration.java
>  0dcdebd 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/CloudStackTestNGBase.java
>  dc7223c 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentManagerSimpleImpl.java
>  575bc8e 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/DirectAgentTest.java
>  fc4aea8 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockHostEndpointRpcServerDirectCallResource.java
>  4ec2436 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockHypervisorHostEndPointRpcServer.java
>  8fc161b 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockLocalHostEndPoint.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockStorageMotionStrategy.java
>  a84f308 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/S3TemplateTest.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/TemplateTest.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/VolumeTest.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/VolumeTestVmware.java
>  PRE-CREATION 
>   
> engine/storage/integration-test/test/org/apache/cloudstack/storage/test/volumeServiceTest.java
>  35a1790 
>   engine/storage/integration-test/test/resource/s3_testng.xml PRE-CREATION 
>   engine/storage/integration-test/test/resource/storageContext.xml 7c5382d 
>   engine/storage/integration-test/test/resource/testng.xml db32c24 
>   engine/storage/pom.xml 270fe47 
>   engine/storage/snapshot/pom.xml 211cdac 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java
>  fa7772a 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
>  37238b7 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java
>  1b64fd0 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStateMachineManagerImpl.java
>  aa1cf68 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotStrategyBase.java
>  PRE-CREATION 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
>  PRE-CREATION 
>   
> engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/strategy/AncientSnapshotStrategy.java
>  9e666d2 
>   engine/storage/src/org/apache/cloudstack/storage/HostEndpointRpcServer.java 
> a316223 
>   
> engine/storage/src/org/apache/cloudstack/storage/HypervisorHostEndPoint.java 
> 6c49b1a 
>   
> engine/storage/src/org/apache/cloudstack/storage/HypervisorHostEndPointRpcServer.java
>  bc21776 
>   engine/storage/src/org/apache/cloudstack/storage/LocalHostEndpoint.java 
> PRE-CREATION 
>   engine/storage/src/org/apache/cloudstack/storage/RemoteHostEndPoint.java 
> PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/AttachPrimaryDataStoreAnswer.java
>  cd15030 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/AttachPrimaryDataStoreCmd.java
>  8aaca94 
>   engine/storage/src/org/apache/cloudstack/storage/command/CopyCmd.java 
> 10478ef 
>   engine/storage/src/org/apache/cloudstack/storage/command/CopyCmdAnswer.java 
> 53e082e 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/CopyTemplateToPrimaryStorageAnswer.java
>  b248758 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/CreateObjectAnswer.java
>  43540de 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/CreateObjectCommand.java
>  86d3bd4 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/CreatePrimaryDataStoreCmd.java
>  0e50950 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/CreateVolumeFromBaseImageCommand.java
>  1734bc4 
>   engine/storage/src/org/apache/cloudstack/storage/command/DeleteCommand.java 
> 5d948d1 
>   
> engine/storage/src/org/apache/cloudstack/storage/command/StorageSubSystemCommand.java
>  d14161a 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataObjectManager.java
>  20bf054 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataObjectManagerImpl.java
>  9d1afbe 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  a2fd08d 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManager.java
>  d170f5c 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
>  87ba1d2 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/provider/DataStoreProviderManagerImpl.java
>  40a65dc 
>   
> engine/storage/src/org/apache/cloudstack/storage/db/ObjectInDataStoreVO.java 
> 0fbcbb1 
>   
> engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
>  c385abe 
>   
> engine/storage/src/org/apache/cloudstack/storage/endpoint/EndPointSelector.java
>  6910eb6 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/ImageDataStoreDriver.java
>  d352d97 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/ImageStoreDriver.java 
> PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java
>  4d162bb 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageDataStore.java
>  ed2274e 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageDataStoreHelper.java
>  3f1632c 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageDataStoreInfo.java
>  b6b9a2a 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageDataStoreManager.java
>  b6d84cd 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageStoreHelper.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/datastore/ImageStoreProviderManager.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDaoStoreDaoImpl.java
>  3f3e9ca 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDataStoreDao.java
>  d7358be 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDataStoreProviderDao.java
>  1b13b7a 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDataStoreProviderDaoImpl.java
>  0e19dbe 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDataStoreProviderVO.java
>  5cc5b8d 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageDataStoreVO.java
>  4cb402a 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/ImageStoreDetailsDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/motion/ImageMotionService.java
>  908d6d5 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  a6880c3 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionDriver.java 
> 3a59b21 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionService.java
>  5ecbcb3 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java
>  b74e10c 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/DataMotionStrategy.java
>  e3859b4 
>   
> engine/storage/src/org/apache/cloudstack/storage/snapshot/SnapshotEntityImpl.java
>  0a91186 
>   
> engine/storage/src/org/apache/cloudstack/storage/snapshot/SnapshotService.java
>  f3e5c4a 
>   engine/storage/src/org/apache/cloudstack/storage/to/ImageDataStoreTO.java 
> b1de88f 
>   
> engine/storage/src/org/apache/cloudstack/storage/to/ImageOnPrimaryDataStoreTO.java
>  a9a3cc4 
>   
> engine/storage/src/org/apache/cloudstack/storage/to/NfsPrimaryDataStoreTO.java
>  96fb6bb 
>   engine/storage/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 
> aa47e8f 
>   engine/storage/src/org/apache/cloudstack/storage/to/TemplateTO.java bc55ea8 
>   engine/storage/src/org/apache/cloudstack/storage/to/VolumeTO.java c65b652 
>   
> engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
>  5f8daf4 
>   
> engine/storage/src/org/apache/cloudstack/storage/volume/db/PrimaryDataStoreDetailsDaoImpl.java
>  PRE-CREATION 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/DefaultPrimaryDataStore.java
>  31e6908 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/PrimaryDataStoreImpl.java
>  PRE-CREATION 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/driver/DefaultPrimaryDataStoreDriverImpl.java
>  e5ee742 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/lifecycle/DefaultPrimaryDataStoreLifeCycleImpl.java
>  fea02e8 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/DefaultPrimaryDataStoreProviderManagerImpl.java
>  e38c3b3 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
>  PRE-CREATION 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java
>  2f0b43a 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/DefaultPrimaryDatastoreProviderImpl.java
>  8c674dc 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/provider/PrimaryDataStoreProviderManager.java
>  b248758 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/TemplateInstallStrategyImpl.java
>  e099619 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeDataFactoryImpl.java
>  e0ecd16 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
>  ea31be3 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
>  2625354 
>   
> engine/storage/volume/test/org/apache/cloudstack/storage/volume/test/ConfiguratorTest.java
>  122c353 
>   
> framework/ipc/src/org/apache/cloudstack/framework/async/AsyncCallbackDispatcher.java
>  26f46da 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java
>  928183b 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
>  0147682 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
>  9cddb2e 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
>  PRE-CREATION 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageResource.java
>  PRE-CREATION 
>   plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java 
> a626e31 
>   
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockStorageManager.java
>  a90ea9e 
>   
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockStorageManagerImpl.java
>  a50dff6 
>   
> plugins/hypervisors/simulator/src/com/cloud/agent/manager/SimulatorManagerImpl.java
>  ab6eec3 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/AgentRoutingResource.java
>  46df50c 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorDiscoverer.java 
> 00fe356 
>   
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java
>  c121fba 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 
> 55bb1e9 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java
>  2f82b53 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
>  9f260f1 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  37ddaa1 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java
>  95ba317 
>   
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
>  PRE-CREATION 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
>  562a7fe 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  734f72f 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
>  357b433 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java
>  24cb75c 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java
>  bb31136 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
>  PRE-CREATION 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageResource.java
>  7e0ccbe 
>   
> plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java
>  353f2b5 
>   
> plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbelement/ElementChildTestConfiguration.java
>  8a67e84 
>   
> plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/LbChildTestConfiguration.java
>  74e54b2 
>   plugins/pom.xml e49fac9 
>   
> plugins/storage-allocators/random/src/org/apache/cloudstack/storage/allocator/RandomStoragePoolAllocator.java
>  cbe6647 
>   plugins/storage/image/default/pom.xml PRE-CREATION 
>   
> plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackImageStoreLifeCycleImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackImageStoreProviderImpl.java
>  PRE-CREATION 
>   plugins/storage/image/s3/pom.xml 7ab0d3e 
>   
> plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/lifecycle/S3ImageStoreLifeCycleImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/s3/src/org/apache/cloudstack/storage/datastore/provider/S3ImageStoreProviderImpl.java
>  PRE-CREATION 
>   plugins/storage/image/sample/pom.xml PRE-CREATION 
>   
> plugins/storage/image/sample/src/org/apache/cloudstack/storage/datastore/driver/SampleImageStoreDriverImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SampleImageStoreLifeCycleImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/sample/src/org/apache/cloudstack/storage/datastore/provider/SampleImageStoreProviderImpl.java
>  PRE-CREATION 
>   plugins/storage/image/swift/pom.xml PRE-CREATION 
>   
> plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/lifecycle/SwiftImageStoreLifeCycleImpl.java
>  PRE-CREATION 
>   
> plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/provider/SwiftImageStoreProviderImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java
>  0486902 
>   
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
>  7153282 
>   
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
>  826f07a 
>   plugins/storage/volume/sample/pom.xml PRE-CREATION 
>   
> plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/driver/SamplePrimaryDataStoreDriverImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/provider/SamplePrimaryDatastoreProviderImpl.java
>  PRE-CREATION 
>   
> plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidfirePrimaryDataStoreDriver.java
>  f31126c 
>   
> plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidfirePrimaryDataStoreProvider.java
>  650cac8 
>   
> plugins/storage/volume/solidfire/test/org/apache/cloudstack/storage/test/VolumeTest.java
>  dc29fb8 
>   scripts/storage/qcow2/managesnapshot.sh 29b7081 
>   scripts/storage/secondary/create_privatetemplate_from_snapshot_xen.sh 
> PRE-CREATION 
>   server/pom.xml 004d9c8 
>   server/src/com/cloud/agent/AgentManager.java 6c300ea 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
>   server/src/com/cloud/agent/manager/AgentMonitor.java f3f6669 
>   server/src/com/cloud/agent/manager/SynchronousListener.java 074f5a8 
>   
> server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java
>  29e1be9 
>   server/src/com/cloud/api/ApiDBUtils.java 94c873e 
>   server/src/com/cloud/api/ApiResponseHelper.java 9a70d95 
>   server/src/com/cloud/api/query/QueryManagerImpl.java 9872c3a 
>   server/src/com/cloud/api/query/ViewResponseHelper.java 827ae7b 
>   server/src/com/cloud/api/query/dao/ImageStoreJoinDao.java PRE-CREATION 
>   server/src/com/cloud/api/query/dao/ImageStoreJoinDaoImpl.java PRE-CREATION 
>   server/src/com/cloud/api/query/dao/TemplateJoinDao.java PRE-CREATION 
>   server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java PRE-CREATION 
>   server/src/com/cloud/api/query/dao/UserVmJoinDao.java 2617a74 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 77c3c44 
>   server/src/com/cloud/api/query/vo/ImageStoreJoinVO.java PRE-CREATION 
>   server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java d86726c 
>   server/src/com/cloud/api/query/vo/TemplateJoinVO.java PRE-CREATION 
>   server/src/com/cloud/capacity/CapacityManager.java bdd9ccd 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 1eb2fa5 
>   server/src/com/cloud/capacity/ComputeCapacityListener.java 16e154a 
>   server/src/com/cloud/capacity/StorageCapacityListener.java bc03f72 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java e1aaa50 
>   server/src/com/cloud/consoleproxy/AgentHook.java 5b6d585 
>   server/src/com/cloud/consoleproxy/AgentHookBase.java 2748a8c 
>   server/src/com/cloud/consoleproxy/ConsoleProxyListener.java a3b7264 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManager.java faec513 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 9a7a46f 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java ca1644a 
>   server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java 
> 75b007c 
>   server/src/com/cloud/network/NetworkManagerImpl.java 9440286 
>   server/src/com/cloud/network/NetworkUsageManagerImpl.java 80f898b 
>   server/src/com/cloud/network/SshKeysDistriMonitor.java 82f72de 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
> 29ef0d5 
>   server/src/com/cloud/network/security/SecurityGroupListener.java 3245253 
>   server/src/com/cloud/resource/ResourceManagerImpl.java 0ab35dd 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java 6d929c6 
>   server/src/com/cloud/server/ManagementServerImpl.java 137f07e 
>   server/src/com/cloud/server/StatsCollector.java 05be0e2 
>   server/src/com/cloud/storage/CreateSnapshotPayload.java PRE-CREATION 
>   server/src/com/cloud/storage/LocalStoragePoolListener.java 244f7fb 
>   server/src/com/cloud/storage/StorageManagerImpl.java 1d4dcef 
>   server/src/com/cloud/storage/StoragePoolAutomationImpl.java 9bba979 
>   server/src/com/cloud/storage/TemplateProfile.java 0b55f1f 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 2f4b2c8 
>   server/src/com/cloud/storage/dao/GuestOSHypervisorDao.java PRE-CREATION 
>   server/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java PRE-CREATION 
>   server/src/com/cloud/storage/download/DownloadAbandonedState.java 200683c 
>   server/src/com/cloud/storage/download/DownloadActiveState.java f2cd5af 
>   server/src/com/cloud/storage/download/DownloadCompleteState.java 6e8edcb 
>   server/src/com/cloud/storage/download/DownloadErrorState.java 0fdfd52 
>   server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
>   server/src/com/cloud/storage/download/DownloadMonitor.java 897befa 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java 220cbff 
>   server/src/com/cloud/storage/download/DownloadState.java 471ab61 
>   server/src/com/cloud/storage/download/NotDownloadedState.java 7752173 
>   server/src/com/cloud/storage/listener/StoragePoolMonitor.java f957ca3 
>   server/src/com/cloud/storage/listener/StorageSyncListener.java d9282a3 
>   server/src/com/cloud/storage/resource/DummySecondaryStorageResource.java 
> 8f25514 
>   server/src/com/cloud/storage/s3/S3Manager.java 0f74e43 
>   server/src/com/cloud/storage/s3/S3ManagerImpl.java 61e5573 
>   server/src/com/cloud/storage/secondary/SecondaryStorageListener.java 
> 6635b3c 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 3cf9a7e 
>   server/src/com/cloud/storage/secondary/SecondaryStorageVmManager.java 
> d315d22 
>   server/src/com/cloud/storage/snapshot/SnapshotManager.java 8181330 
>   server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 26aae48 
>   server/src/com/cloud/storage/swift/SwiftManagerImpl.java 5a7f01a 
>   server/src/com/cloud/storage/upload/UploadListener.java ee13cf9 
>   server/src/com/cloud/storage/upload/UploadMonitor.java 1c3590e 
>   server/src/com/cloud/storage/upload/UploadMonitorImpl.java 77f0d20 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
>   server/src/com/cloud/template/TemplateAdapter.java 9a2d877 
>   server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e 
>   server/src/com/cloud/template/TemplateManager.java 19ba3b5 
>   server/src/com/cloud/template/TemplateManagerImpl.java a8729e1 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java 521b5e0 
>   server/src/com/cloud/vm/VirtualMachineProfileImpl.java 24f44cb 
>   server/test/com/cloud/agent/MockAgentManagerImpl.java 7e3462d 
>   server/test/com/cloud/resource/MockResourceManagerImpl.java 5202c31 
>   
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java 
> 6f52397 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/CifsSecondaryStorageResource.java
>  de4cfe0 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/LocalNfsSecondaryStorageResource.java
>  PRE-CREATION 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/LocalSecondaryStorageResource.java
>  b904254 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
>  e7fa5b2 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java
>  d3af792 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/template/DownloadManager.java
>  3e5072a 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
>  a9d23cb 
>   setup/db/db/schema-410to420.sql 334aae7 
>   test/integration/smoke/test_volumes.py 4bf8203 
>   tools/apidoc/gen_toc.py 8b6460e 
>   tools/devcloud/devcloud.cfg e6ab71b 
>   tools/devcloud/devcloud_s3.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 4e82bbe 
>   tools/marvin/marvin/deployDataCenter.py 7059059 
>   ui/scripts/cloudStack.js b943a94 
>   ui/scripts/system.js 0164e21 
>   ui/scripts/zoneWizard.js 9b28c32 
>   utils/src/com/cloud/utils/S3Utils.java b7273a1 
>   utils/src/com/cloud/utils/UriUtils.java 3bcee7a 
>   utils/src/com/cloud/utils/script/Script.java 3632bf5 
> 
> Diff: https://reviews.apache.org/r/11277/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> edison su
> 
>

Reply via email to