> On May 21, 2013, 5:45 a.m., Nitin Mehta wrote: > > server/src/com/cloud/storage/VolumeManagerImpl.java, line 920 > > <https://reviews.apache.org/r/11296/diff/1/?file=295144#file295144line920> > > > > Can you please put the check above the if (cmd.getSnapshotId() == null) > > else block because this should be working for both volume created from > > snapshot or a fresh volume.
Nitin, I have moved the fix outside the if (cmd.getSnapshotId() == null) else block, so it is working for both volume creation (fresh and from snapshot). Does it matter if it is above or below the if else block? - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11296/#review20818 ----------------------------------------------------------- On May 21, 2013, 5:24 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11296/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 5:24 a.m.) > > > Review request for cloudstack, Devdeep Singh and Nitin Mehta. > > > Description > ------- > > CLOUDSTACK-2305: [Automation] NPE: not able to create volume from snapshot > > > This addresses bug CLOUDSTACK-2305. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeManagerImpl.java 55e20cf > > Diff: https://reviews.apache.org/r/11296/diff/ > > > Testing > ------- > > Verified on my local CloudStack setup. > > > Thanks, > > Sanjay Tripathi > >
