Thanks Chip ! -----Original Message----- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Monday, May 20, 2013 11:29 PM To: dev@cloudstack.apache.org Subject: Re: MidoNetElementTest Issue
On Mon, May 20, 2013 at 08:29:49AM +0000, Pranav Saxena wrote: > Thanks Dave . I'll apply the change after running mvn clean install test > again . Applied. > > Regards, > Pranav > > -----Original Message----- > From: dcah...@midokura.jp [mailto:dcah...@midokura.jp] On Behalf Of > Dave Cahill > Sent: Monday, May 20, 2013 1:41 PM > To: CloudStack Dev > Subject: Re: MidoNetElementTest Issue > > Hi, > > Mike - thanks for the heads up! I did an mvn clean install test and couldn't > see the warning, but your change certainly makes sense. > > Pranav - I made the change and submitted to ReviewBoard with you > marked as a reviewer:* *https://reviews.apache.org/r/11232/ > > Thanks, > Dave. > > > On Sat, May 18, 2013 at 10:50 AM, Mike Tutkowski < > mike.tutkow...@solidfire.com> wrote: > > > It's located in this folder: > > > > plugins/network-elements/midonet/test/com/cloud/network/element > > > > I don't know what this code does, but it looks like the following > > import is listed twice: > > > > import com.cloud.network.element.MidoNetElement; > > > > I think the first one (which is the first import) should be changed > > to a package as such: > > > > package com.cloud.network.element; > > > > I have a bunch of code that needs to get reviewed and checked in > > before 5/31, so I could just make this change. > > > > I just figured - if it was easy for a committer - we could just fix it now. > > :) > > > > > > > > On Fri, May 17, 2013 at 7:44 PM, Pranav Saxena > > <pranav.sax...@citrix.com > > >wrote: > > > > > I can do so , but only If you could point me to the file and the > > > change which needs to be done . But before that , I would suggest > > > you to raise a JIRA ticket for the same so that we can track it as well . > > > > > > Thanks, > > > Pranav > > > > > > -----Original Message----- > > > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] > > > Sent: Saturday, May 18, 2013 6:54 AM > > > To: dev@cloudstack.apache.org > > > Subject: MidoNetElementTest Issue > > > > > > Hi, > > > > > > If someone has committer privileges, perhaps you could provide > > > MidoNetElementTest a package declaration. I notice it's coming up > > > with a warning because of that. > > > > > > Thanks! > > > > > > -- > > > *Mike Tutkowski* > > > *Senior CloudStack Developer, SolidFire Inc.* > > > e: mike.tutkow...@solidfire.com > > > o: 303.746.7302 > > > Advancing the way the world uses the > > > cloud<http://solidfire.com/solution/overview/?video=play> > > > *(tm)* > > > > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the > > cloud<http://solidfire.com/solution/overview/?video=play> > > *(tm)* > > >
