----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11177/#review20750 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On May 17, 2013, 12:56 p.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11177/ > ----------------------------------------------------------- > > (Updated May 17, 2013, 12:56 p.m.) > > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min > Chen. > > > Description > ------- > > CLOUDSTACK-1901: API:MS: DeleteEvents deletes Archived events as well > > > This addresses bug CLOUDSTACK-1901. > > > Diffs > ----- > > engine/schema/src/com/cloud/alert/dao/AlertDaoImpl.java 4b9bc6a > engine/schema/src/com/cloud/event/dao/EventDaoImpl.java 0d3d38a > > Diff: https://reviews.apache.org/r/11177/diff/ > > > Testing > ------- > > Tests: > 1. Archive some events (these events will not appear in the listEvents call). > 2. Delete events by type of olderthan. > 3. Observed that the archived events are still there in DB. > > > Thanks, > > Sanjay Tripathi > >
