----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10860/#review20166 -----------------------------------------------------------
I have committed my changes to master , so you could probably discard this review request . Again , thanks for catching this loophole here . - Pranav Saxena On April 30, 2013, 7:43 a.m., Isaac Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10860/ > ----------------------------------------------------------- > > (Updated April 30, 2013, 7:43 a.m.) > > > Review request for cloudstack and Pranav Saxena. > > > Description > ------- > > According to CS' fronend logic, there is a general error handling function in > cloudStack.js line 95. Hense this is a common issue for detail view when a > request failed from server. > This patch try not to against current UI logic and provide a statusCode > callback to capture failed request. The added callback will remove loading > div from detailView. > This patch is a suggested solution to the issue. > > Thanks > > > This addresses bug CLOUDSTACK-2274. > > > Diffs > ----- > > ui/scripts/system.js 7aa0566 > > Diff: https://reviews.apache.org/r/10860/diff/ > > > Testing > ------- > > Test from UI and work well > > > Thanks, > > Isaac Chiang > >
