----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10570/#review20114 -----------------------------------------------------------
Ship it! Commit c8e3fff6e43954bdd0c33aabcd0c17fa3799c4f3 in branch refs/heads/master - Sateesh Chodapuneedi On April 17, 2013, 11:59 a.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10570/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 11:59 a.m.) > > > Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram > Ganesh. > > > Description > ------- > > By default monitor retires value is '3'. > Fixed the issue, while creating the monitor setting the retires value in > monitor object to max of (HealthcheckThresshold , UnhealthThresshold) + 1 > > > Diffs > ----- > > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > b82176b > > Diff: https://reviews.apache.org/r/10570/diff/ > > > Testing > ------- > > 1. Verified the creation of monitor with params value more than '3' monitor > is getting created. > 2. verified the monitor properties in the Netscaler properties are saved > accordingly. > 3. Verified creating the monitor for TCP/HTTP types. > 4. deletion of monitor works well. > > > Thanks, > > Rajesh Battala > >