> On April 23, 2013, 8:58 p.m., David Nalley wrote: > > In the process of fixing this bug, can we also write a test that ensure we > > don't regress it in the future? > >
David, There is a separate ticket created to test the limit resources on domain/accounts under [QA Automation] tag: https://issues.apache.org/jira/browse/CLOUDSTACK-1466 I'll work with Prasanna to complete the tests for all the resource types. There is already a patch on the review board which tests the CPU limits: https://reviews.apache.org/r/10828/ submitted by Chiraj Jog. - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10725/#review19602 ----------------------------------------------------------- On April 23, 2013, 9:29 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10725/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 9:29 a.m.) > > > Review request for cloudstack, Devdeep Singh, Nitin Mehta, Sateesh > Chodapuneedi, and Min Chen. > > > Description > ------- > > CLOUDSTACK-2087: Destroying the instance is not decrementing the primary > storage usage [Resource Count table - No of volumes is not got decremented] > > > This addresses bug CLOUDSTACK-2087. > > > Diffs > ----- > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15 > > Diff: https://reviews.apache.org/r/10725/diff/ > > > Testing > ------- > > Tests: > 1. Deploy an instance from a user account. > 2. Check the updated resource count (primary storage and volume). > 3. Destroy the same instance. > 4. Verify the decremented resource count from the account detailView. > > > Thanks, > > Sanjay Tripathi > >
