----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10774/#review19706 -----------------------------------------------------------
Did not test your patch but saw the diff. Mostly looks good, we'll wait for other reviewers to review, test and ship! patches/systemvm/debian/config/etc/init.d/cloud-early-config <https://reviews.apache.org/r/10774/#comment40645> Remove comment if not needed? patches/systemvm/debian/config/etc/init.d/cloud-early-config <https://reviews.apache.org/r/10774/#comment40646> Is this file for ipv6? I see a rules.v4? - Rohit Yadav On April 25, 2013, 10:35 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10774/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 10:35 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, edison su, Chiradeep > Vittal, Rohit Yadav, and anthony xu. > > > Description > ------- > > Updated the cloud early config also to copy the /etc/iptables/iptables-router > (iptables-*) to /etc/iptables/rules. > > > This addresses bug CLOUDSTACK-2161. > > > Diffs > ----- > > patches/systemvm/debian/config/etc/init.d/cloud-early-config 187ae25 > > Diff: https://reviews.apache.org/r/10774/diff/ > > > Testing > ------- > > Tested by copying cloud-early-config to router with old template. > > > Thanks, > > Jayapal Reddy > >