On Wed, Apr 24, 2013 at 09:02:09AM -0700, Chiradeep Vittal wrote: > CS has always had the ability to accept POST for any api.
Oh I don't know about that. Because it seems like Vijay has had to drill down the HTTP Method into the API layer. Changes to the BaseCmd.java indicate the method (GET/POST) that the request came through and that is sent down to the manager classes to run custom business logic - in Vijay's case it was the sizeof(userdata) Perhaps doPost() has always been supported by the ApiServlet and that's what you meant? I may be wrong - but if POST was always supported we should have been able to send userdata without any changes. -- Prasanna., > > On 4/24/13 1:38 AM, "Prasanna Santhanam" <t...@apache.org> wrote: > > >Vijay added the ability to send userdata as POST for the > >deployVirtualMachine API in review [1]. What I'd like to address here > >is how to expose this via ApiDiscovery so that clients like marvin, > >cloudmonkey can autogenerate themselves to support APIs of this > >kind. This also needs to be clearly specified in our API docs. > > > >I'm guessing we'll have to put in additional annotations on our APIs > >that support POST so that API discovery can print the methods > >supported (GET/POST). Right now it's only the deployVMCmd (AFAIK). But > >I expect this will need to be done for others soon. > > > >I've included POST support for _every_ command in marvin but that's > >just brute-force. To make it more intelligent I think we should apply > >it to only apis that make sense as POST (causing side-effects). But > >that needs to be exposed by the api endpoint. > > > >Thoughts? > > > >[1] https://reviews.apache.org/r/10294/ > > > >-- > >Prasanna., > > > >------------------------ > >Powered by BigRock.com > > ------------------------ Powered by BigRock.com
