----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10703/#review19617 -----------------------------------------------------------
server/src/com/cloud/api/ApiResponseHelper.java <https://reviews.apache.org/r/10703/#comment40528> I don't think we should be passing VLAN information in NicResponse. Its important that we pass network ID to which this NIC belong. I dont see network id being set in the nic response. - Murali Reddy On April 22, 2013, 11:10 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10703/ > ----------------------------------------------------------- > > (Updated April 22, 2013, 11:10 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > > > Description > ------- > > Updated listnics response for normal user > > > This addresses bug CLOUDSTACK-1573. > > > Diffs > ----- > > server/src/com/cloud/api/ApiResponseHelper.java a7d6165 > > Diff: https://reviews.apache.org/r/10703/diff/ > > > Testing > ------- > > Tested with admin and normal user > > > Thanks, > > Jayapal Reddy > >
