----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10727/#review19616 -----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/10727/#comment40527> you need to check for both 'isolated' & 'shared' networks of advanced zone. server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/10727/#comment40526> You need to check for only basic zone here. 'shared' network of advanced zone is different from 'shared' network of basic zone w.r.t to guest IP allocation. server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/10727/#comment40525> this check is required, dont remove it. server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/10727/#comment40524> This check needs to be done for both advanced/basic zones and isolate/shared networks. also you need to check if NIC is owned/usable by caller. No need for check access on VM - Murali Reddy On April 23, 2013, 10:55 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10727/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 10:55 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Murali Reddy. > > > Description > ------- > > Updated the user permissions check > > > This addresses bug CLOUDSTACK-2134. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45 > > Diff: https://reviews.apache.org/r/10727/diff/ > > > Testing > ------- > > Unit tested on basic and advanced zone > > > Thanks, > > Jayapal Reddy > >
