On 20/04/13 1:09 AM, "Rohit Yadav" <bhais...@apache.org> wrote:
>On Fri, Apr 19, 2013 at 9:22 AM, Marcus Sorensen ><shadow...@gmail.com>wrote: > >> Er, I guess you're asking about the mkdir specifically. I have no idea >>why >> we'd be doing that in the first place, I'd also be interested in knowing >> that. >> > > >One of the hacks to make sure a file does not get created on a *nix fs is >to remove the file and make a directory with the same file name. So, this >answers the "why" :) > >Abhi suggested that it was causing an issue. In his rinse-repeat-test fix, >he had to remove the directory to make it work with the systemvm appliance >for vmware. As Marcus pointed out the initialisation scripts on the Router systemVM actually tie the interfaces with mac addresses using udev rules. Since the file pre existed in form of directory the file creation failed. The failure resulted in template failing to initialise and rendered it useless. The new VMWare system template that works is now published in another thread and related bug. > > >> On Apr 18, 2013 9:51 PM, "Marcus Sorensen" <shadow...@gmail.com> wrote: >> >> > Those udev rules are often a pain when using VM templates. Their >>purpose >> > is to tie a specific MAC address to an eth# dev, so for example if you >> > configure an IP address for eth0 and then change the mac address (via >>VM >> > clone or some such), you suddenly have no IP at all, no eth0, and an >>eth1 >> > tied to the new MAC. >> > >> > The rule in /etc has the MAC to eth# mappings, and the one in /lib >> creates >> > the one in /etc. >> > On Apr 18, 2013 9:41 PM, "Chip Childers" <chip.child...@sungard.com> >> > wrote: >> > >> >> >> >> Hey Rohit, >> >> >> >> Can you explain the change below? I'm mostly curious. >> >> >> >> On Fri, Apr 19, 2013 at 03:36:36AM +0000, bhais...@apache.org wrote: >> >> > Updated Branches: >> >> > refs/heads/master ca6873a9d -> 81e1ba3bb >> >> > >> >> > >> >> > appliance: Don't mkdir 70-persistent-net.rules for systemvms >> >> > >> >> > Signed-off-by: Rohit Yadav <bhais...@apache.org> >> >> > >> >> > >> >> > Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo >> >> > Commit: >> >> http://git-wip-us.apache.org/repos/asf/cloudstack/commit/81e1ba3b >> >> > Tree: >>http://git-wip-us.apache.org/repos/asf/cloudstack/tree/81e1ba3b >> >> > Diff: >>http://git-wip-us.apache.org/repos/asf/cloudstack/diff/81e1ba3b >> >> > >> >> > Branch: refs/heads/master >> >> > Commit: 81e1ba3bb406f9546f0d46ccbfa3fbbb35b762e2 >> >> > Parents: ca6873a >> >> > Author: Rohit Yadav <bhais...@apache.org> >> >> > Authored: Fri Apr 19 09:05:42 2013 +0530 >> >> > Committer: Rohit Yadav <bhais...@apache.org> >> >> > Committed: Fri Apr 19 09:05:42 2013 +0530 >> >> > >> >> > >>---------------------------------------------------------------------- >> >> > .../definitions/systemvmtemplate/cleanup.sh | 1 - >> >> > .../definitions/systemvmtemplate64/cleanup.sh | 1 - >> >> > 2 files changed, 0 insertions(+), 2 deletions(-) >> >> > >>---------------------------------------------------------------------- >> >> > >> >> > >> >> > >> >> >> >>http://git-wip-us.apache.org/repos/asf/cloudstack/blob/81e1ba3b/tools/app >>liance/definitions/systemvmtemplate/cleanup.sh >> >> > >>---------------------------------------------------------------------- >> >> > diff --git >>a/tools/appliance/definitions/systemvmtemplate/cleanup.sh >> >> b/tools/appliance/definitions/systemvmtemplate/cleanup.sh >> >> > index 9e98ab0..701d8d8 100644 >> >> > --- a/tools/appliance/definitions/systemvmtemplate/cleanup.sh >> >> > +++ b/tools/appliance/definitions/systemvmtemplate/cleanup.sh >> >> > @@ -12,7 +12,6 @@ rm /var/lib/dhcp/* >> >> > # Make sure Udev doesn't block our network >> >> > echo "cleaning up udev rules" >> >> > rm /etc/udev/rules.d/70-persistent-net.rules >> >> > -mkdir /etc/udev/rules.d/70-persistent-net.rules >> >> > rm -rf /dev/.udev/ >> >> > rm /lib/udev/rules.d/75-persistent-net-generator.rules >> >> > >> >> > >> >> > >> >> >> >>http://git-wip-us.apache.org/repos/asf/cloudstack/blob/81e1ba3b/tools/app >>liance/definitions/systemvmtemplate64/cleanup.sh >> >> > >>---------------------------------------------------------------------- >> >> > diff --git >>a/tools/appliance/definitions/systemvmtemplate64/cleanup.sh >> >> b/tools/appliance/definitions/systemvmtemplate64/cleanup.sh >> >> > index 9e98ab0..701d8d8 100644 >> >> > --- a/tools/appliance/definitions/systemvmtemplate64/cleanup.sh >> >> > +++ b/tools/appliance/definitions/systemvmtemplate64/cleanup.sh >> >> > @@ -12,7 +12,6 @@ rm /var/lib/dhcp/* >> >> > # Make sure Udev doesn't block our network >> >> > echo "cleaning up udev rules" >> >> > rm /etc/udev/rules.d/70-persistent-net.rules >> >> > -mkdir /etc/udev/rules.d/70-persistent-net.rules >> >> > rm -rf /dev/.udev/ >> >> > rm /lib/udev/rules.d/75-persistent-net-generator.rules >> >> > >> >> > >> >> > >> >> >> > >>
