----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10005/#review19396 -----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java <https://reviews.apache.org/r/10005/#comment40106> This code seems dueplicated because the logic to calculate reserved ip range can be used to check if there exists some ip range to be reserved or not. If the calculated range is empty then do not attempt to reserve. Code to prepare response object already had this logic. May be we have to move this to NetUtils and call that from both places. - Sateesh Chodapuneedi On March 19, 2013, 9:07 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10005/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 9:07 a.m.) > > > Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi. > > > Description > ------- > > In cases where the start ip and end ip of guest vm cidr and network cidr are > same, even when the cidrs appear to be different,the reservation procedure > should not go through and user should get a message mentioning that. > Added extra check for the same with proper alert message. > > > This addresses bug CLOUDSTACK-1647. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java 52e81e5 > > Diff: https://reviews.apache.org/r/10005/diff/ > > > Testing > ------- > > CIDR : 10.0.144.0/20, Network CIDR : null, guestVmCidr : 10.0.151.0/20 => > Reservation is not applied. > CIDR : 10.0.144.0/21, Network CIDR : 10.0.144.0/20, guestVmCidr : > 10.0.151.0/20 => Existing Reservation is not affected. > > > Thanks, > > Saksham Srivastava > >
